This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Expose GetInputType as a protected member of InputTagHelper.
#5104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// <see cref="ModelExplorer.Metadata"/>. Input type hints are typically used to format an | ||
| /// <input> elements "value" attribute of a generated text box or used to determine if a text box should | ||
| /// be multi-line.</remarks> | ||
| protected string GetInputType(ModelExplorer modelExplorer, out string inputTypeHint) |
There was a problem hiding this comment.
For the future, please do not move methods around while making other changes. It makes it harder to see what's really changing. We also aren't that persnickety about order in existing classes and someone could do a pass reordering class members on some future Engineering Day.
|
⌚ |
|
🆙 📅 |
| /// </summary> | ||
| /// <param name="modelExplorer">The <see cref="ModelExplorer"/> to use.</param> | ||
| /// <param name="inputTypeHint">When this method returns, contains a type hint associated with the given | ||
| /// <paramref name="modelExplorer"/>.</param> |
There was a problem hiding this comment.
Closer to ... contains the string, often the name of a <see cref="ModelMetadata.ModelType"/> base class, used to determine this method's return value.
|
|
w/ one last comment on a doc comment to update the comment as I've commented.
- Added doc comments. #4979
NTaylorMullen
force-pushed
the
nimullen/inputtype.4979
branch
from
d71681e to
663f6a1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change access modifier for InputTagHelper.GetInputType #4979