This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Add ModelBindingResult.IsFatalError and make body binding more consistent
#2695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istent - part I of II for #2445 (with a duplicate code PR to follow) - needed for #2445 because new `ModelState` entries for values will make inconsisteny worse - change `BodyModelBinder` to use same keys for all `ModelBindingResult`s and `ModelState` entries - return fatal error result if formatter adds an error to `ModelState` - update potential callers to avoid avoid ignoring `IsFatalError` - fix test attempting to serialize all of `ModelState` - will be borked with additional `RawValue`s in state - fix two other tests that serialized `ModelState` but checked only `IsValid` nits: - address minor inconsistencies in `ModelBindingContext` - use `System.Reflection.Extensions` package a bit more, where it's already referenced - remove some unused resources
|
/cc @harshgMSFT @rynowak |
This was referenced Jun 14, 2015
| /// Creates a new <see cref="ModelBindingResult"/> indicating a fatal error. | ||
| /// </summary> | ||
| /// <param name="key">The key using which was used to attempt binding the model.</param> | ||
| public ModelBindingResult(string key) |
There was a problem hiding this comment.
In future PRs remove all public constructors and use explicit static factory methods instead.
There was a problem hiding this comment.
@rynowak if you feel strongly about the factory method approach, please file a bug. I hesitate because this would affect all IModelBinder implementations.
|
|
from
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ModelStateentries for values will make inconsisteny worseBodyModelBinderto use same keys for allModelBindingResults andModelStateentriesModelStateIsFatalErrorModelStateRawValues in stateModelStatebut checked onlyIsValidnits:
ModelBindingContextSystem.Reflection.Extensionspackage a bit more, where it's already referenced