This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
Add ModelBindingContext.IsFirstChanceBinding and IsTopLevelObject
#2697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @harshgMSFT @rynowak This PR builds on #2695 and #2696. Technically, this PR is optional but it corrects some (corner case?) behaviours and simplifies the code. |
| public bool IsTopLevelObject { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Gets or sets an indication that a parent binder will make another binding attempt (e.g. fall back to the |
There was a problem hiding this comment.
s/parent binder/model binding system/
|
|
from 
dougbu
force-pushed
the
dougbu/more.state.2445.II
branch
from
8be42f8 to
f0ae34d
Compare
- cleanup duplicate code now that #2445 is fixed - update unit tests using old `ModelBindingContext` setups - fix (just) one integration test where `MutableObjectModelBinder` incorrectly calculated `isTopLevelObject` and returned a non-`null` model - undo temporary changes in `BodyModelBinderTests` due to increased reliance on incorrect `isTopLevelObject` in #2445 fix nits: - combine tests that are now duplicates - beef up coverage of some `MutableObjectModelBinderTest` cases
- "a parent binder" -> "the model binding system" - remove unused `using`s
dougbu
force-pushed
the
dougbu/model.binding.cleanup
branch
from
37fd9d1 to
10a21db
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ModelBindingContextsetupsMutableObjectModelBinderincorrectly calculatedisTopLevelObjectand returned a non-nullmodelnits:
MutableObjectModelBinderTestcases