Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

DefaultAssemblyPartDiscoveryProvider.IsCandidateLibrary should not look at types i… #4378

Closed
wants to merge 1 commit into from

Conversation

pranavkm
Copy link
Contributor

…n Mvc assemblies

Fixes #4363

@pranavkm
Copy link
Contributor Author

cc @javiercn \ @rynowak

@javiercn
Copy link
Member

This will affect AddTagHelpersAsServices as we need to discover the ones we provide out of the box.

@javiercn
Copy link
Member

Also, I'm working on dramatic change to this class, we might want to wait and do it later

@pranavkm
Copy link
Contributor Author

@javiercn, what's the PR for your change?

@javiercn
Copy link
Member

#4379

@javiercn
Copy link
Member

javiercn commented Apr 1, 2016

You can rebase this PR on top of my changes :)

@pranavkm pranavkm changed the title DefaultAssemblyProvider.IsCandidateLibrary should not look at types i… DefaultAssemblyPartDiscoveryProvider.IsCandidateLibrary should not look at types i… Apr 3, 2016
@pranavkm
Copy link
Contributor Author

pranavkm commented Apr 3, 2016

🆙 📅

@javiercn
Copy link
Member

javiercn commented Apr 3, 2016

Is there anything that we provide out of the box apart from tag helpers? (I'm pretty sure we don't, but want to make sure). If there's something else that we provide out of the box, you need to add it to the list of default parts. If not, :shipit:

@pranavkm
Copy link
Contributor Author

pranavkm commented Apr 3, 2016

Sorry, I don't understand what out of the box means here.

@javiercn
Copy link
Member

javiercn commented Apr 3, 2016

As part of the framework, like input tag helper and similar, I don't think we provide any view component or a controller, but just wanted to make you aware. :shipit:

@pranavkm pranavkm closed this Apr 4, 2016
@pranavkm pranavkm deleted the prkrishn/4363 branch April 4, 2016 01:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants