This repository has been archived by the owner on Dec 14, 2018. It is now read-only.
[Proposal][Fixes #4187] Get rid of DNX services #4379
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@javiercn - do they have to add the 'entry' assembly or do they get that for free? |
| /// <summary> | ||
| /// A type that uses Roslyn to compile C# content and <see cref="ILibraryExporter"/> to find out references. | ||
| /// </summary> | ||
| public class DnxRoslynCompilationService : ICompilationService |
There was a problem hiding this comment.
We might need to find an alternative for this. Can we make the default implementation make use of ApplicationPartManager to get the list of referenced assemblies?
There was a problem hiding this comment.
That's a different matter entirely. These are not the same.
|
|
||
| namespace Microsoft.AspNetCore.Mvc.Infrastructure | ||
| { | ||
| public class DnxAssemblyProvider : IAssemblyProvider |
There was a problem hiding this comment.
Couldn't we just port this? The API doesn't seem significantly different and it avoids breaking people again.
Closed
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need IAssemblyProvider anymore as we have application parts, this commit removes support for IAssemblyProvider from MVC and DNX assembly provider. For customers running on RC1 using DNX that want to use nightly bits, the alternative is to add their assemblies manually to the IMvcBuilder.ApplicationPartManager during startup.