[red-knot] statically-known branches #12700
Comments
This was referenced Nov 7, 2024
This was referenced Dec 5, 2024
sharkdp
added a commit
that referenced
this issue
Dec 5, 2024
## Summary `typing_extensions` has a `>=3.13` re-export for the `typing.NoDefault` singleton, but not for `typing._NoDefaultType`. This causes problems as soon as we understand `sys.version_info` branches, so we explicity switch to `typing._NoDefaultType` for Python 3.13 and later. This is a part of #14759 that I thought might make sense to break out and merge in isolation. ## Test Plan New test that will become more meaningful with #12700 --------- Co-authored-by: Micha Reiser <[email protected]>
This was referenced Dec 12, 2024
sharkdp
added a commit
that referenced
this issue
Dec 21, 2024
## Summary This changeset adds support for precise type-inference and boundness-handling of definitions inside control-flow branches with statically-known conditions, i.e. test-expressions whose truthiness we can unambiguously infer as *always false* or *always true*. This branch also includes: - `sys.platform` support - statically-known branches handling for Boolean expressions and while loops - new `target-version` requirements in some Markdown tests which were now required due to the understanding of `sys.version_info` branches. closes #12700 closes #15034 ## Performance ### `tomllib`, -7%, needs to resolve one additional module (sys) | Command | Mean [ms] | Min [ms] | Max [ms] | Relative | |:---|---:|---:|---:|---:| | `./red_knot_main --project /home/shark/tomllib` | 22.2 ± 1.3 | 19.1 | 25.6 | 1.00 | | `./red_knot_feature --project /home/shark/tomllib` | 23.8 ± 1.6 | 20.8 | 28.6 | 1.07 ± 0.09 | ### `black`, -6% | Command | Mean [ms] | Min [ms] | Max [ms] | Relative | |:---|---:|---:|---:|---:| | `./red_knot_main --project /home/shark/black` | 129.3 ± 5.1 | 119.0 | 137.8 | 1.00 | | `./red_knot_feature --project /home/shark/black` | 136.5 ± 6.8 | 123.8 | 147.5 | 1.06 ± 0.07 | ## Test Plan - New Markdown tests for the main feature in `statically-known-branches.md` - New Markdown tests for `sys.platform` - Adapted tests for `EllipsisType`, `Never`, etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In cases like
if True:orif False:(or any case where we know the truthiness of a branch test), we should assume that only the possible branch is taken.The text was updated successfully, but these errors were encountered: