[red-knot] Fallback for typing._NoDefaultType
#14783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`typing_extensions` has a `>=3.13` re-export for the `typing.NoDefault` singleton, but not for `typing._NoDefaultType`. This causes problems as soon as we understand `sys.version_info` branches, so we explicity switch to `typing._NoDefaultType` for Python 3.13 and later.
sharkdp
requested review from
carljm,
MichaReiser and
AlexWaygood
as code owners
MichaReiser
reviewed
Dec 5, 2024
Co-authored-by: Micha Reiser <[email protected]>
sharkdp
force-pushed
the
david/no-default-type-fallback
branch
from
9257ffa to
ea2820a
Compare
|
|
I'm merging this to decrease the diff in the statically-known branches PR. It seems relatively uncontroversial, but please let me know if something is off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
typing_extensionshas a>=3.13re-export for thetyping.NoDefaultsingleton, but not fortyping._NoDefaultType. This causes problems as soon as we understandsys.version_infobranches, so we explicity switch totyping._NoDefaultTypefor Python 3.13 and later.This is a part of #14759 that I thought might make sense to break out and merge in isolation.
Test Plan
New test that will become more meaningful with #12700