Change default build type to "minsize" #1463
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
People (and distros) have been building ksh from this project using the default "debug" build type since we switched from Nmake to Meson. That results in a ksh program whose performance is far from optimal. So change the default build type. If a debugging enabled binary is needed, such as in a CI environment, it must be requested explicitly. Related #1449
|
LGTM |
|
Merged with a comment added to CHANGELOG.md. I also cherry-picked this into the 2020.0.1 branch so that future builds by distros will be appropriately optimized even if they don't explicitly use the |
aweeraman
reviewed
Feb 1, 2020
| @@ -1,4 +1,9 @@ | |||
| project('ksh93', 'c', default_options: [ | |||
| project('ksh9', 'c', default_options: [ | |||
There was a problem hiding this comment.
There seems to be a typo here on "ksh9"...
There was a problem hiding this comment.
Just noticed that this is already fixed on trunk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People (and distros) have been building ksh from this project using the
default "debug" build type since we switched from Nmake to Meson. That
results in a ksh program whose performance is far from optimal. So change
the default build type. If a debugging enabled binary is needed, such as
in a CI environment, it must be requested explicitly.
Related #1449