Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default build type to "minsize" #1463

Closed
wants to merge 1 commit into from
Closed

Change default build type to "minsize" #1463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
project('ksh93', 'c', default_options: [
project('ksh9', 'c', default_options: [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a typo here on "ksh9"...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed that this is already fixed on trunk

# This is the optimal production build type for this project. If you need
# a debug build you must explicitly run `meson --buildtype=debug`. This
# helps ensure that each distro (or user) gets a performance optimized build
# even if they don't know to add the `--buildtype=minsize` option.
'buildtype=minsize',
'b_lundef=false',
'default_library=static',
'c_std=c99', # we require the C99 (aka ISO9899:1999) language standard
Expand Down
3 changes: 2 additions & 1 deletion scripts/build-on-docker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ mkdir build
cd build

echo ==== Configuring the build
if ! meson -Dwarnings-are-errors=true --prefix="$(mktemp -dt ksh.XXXXXX)"
if ! meson -Dwarnings-are-errors=true --prefix="$(mktemp -dt ksh.XXXXXX)" \
--buildtype=debug
then
cat meson-logs/meson-log.txt
exit 1
Expand Down
3 changes: 2 additions & 1 deletion scripts/build-on-macos.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ mkdir build
cd build

echo ==== Configuring the build
if ! meson -Dwarnings-are-errors=true --prefix="$(mktemp -dt ksh.XXXXXX)"
if ! meson -Dwarnings-are-errors=true --prefix="$(mktemp -dt ksh.XXXXXX)" \
--buildtype=debug
then
cat meson-logs/meson-log.txt
exit 1
Expand Down