Expand Lock style customization #432
Conversation
cocojoe
added
the
enhancement
cocojoe
force-pushed
the
added-styling-expanded
branch
from
b0de968 to
bcfe1a7
Compare
cocojoe
force-pushed
the
added-styling-expanded
branch
from
daea63d to
91949ee
Compare
|
|
|
|
||
| func styleSubViews(style: Style) { | ||
| self.subviews.forEach { view in |
There was a problem hiding this comment.
Can you explain how this work?. If you already styled the component you could potentially call it twice right?
There was a problem hiding this comment.
My point is if we iterate on all subviews we could just call this method. Otherwise I'd rather call all the explicit nth-child since messing with the hierarchy could avoid a subview to be styled correctly
There was a problem hiding this comment.
Yes potentially if you don't watch your styling order in apply e.g. apply manually to a component in apply and then call styleSubViews.
The reason I avoided nth-child calling was when you came to inputViews in Forms. It becomes awkward to access and you end up writing the equivalent of this method to loop through all the InputFields in a Signup Form and apply style anyway.
I think we should just call the styleSubViews at present.
|
Screenshots updated in https://lit-shelf-28379.herokuapp.com/screenshots.html |
Added InputField Styling Refactor Color Instances into Style Added UI Tests for Screenshots with fastlane snapshot
Allow CustomTextField with no icon #409
Fix Header Button Image Scaling, Position
Database Login/Signup Tabs customization SecondaryButton customization StatusBar customization. Request #416 Ensure styling Enteprise Active Auth Expand snapshot coverage
Primarybutton AttributedTitle color cusomization
cocojoe
force-pushed
the
added-styling-expanded
branch
2 times, most recently
from
2182358 to
649abe0
Compare
cocojoe
force-pushed
the
added-styling-expanded
branch
from
649abe0 to
fe5d3a7
Compare
Style comparison screenshots Standard vs Custom.
https://lit-shelf-28379.herokuapp.com/screenshots.html
(Free Heroku so if times out, just retry)