Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated AuthButton style [SDK-1376] #599

Merged
merged 3 commits into from
Feb 14, 2020
Merged

Updated AuthButton style [SDK-1376] #599

merged 3 commits into from
Feb 14, 2020

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Feb 14, 2020

Changes

Updated AuthButton to match the new Lock.js style, that was in turn updated to prevent App Store rejections (due to the look of the SIWA button).

  • Added a new property borderColor to AuthStyle
  • Refactored the layout of AuthButton to remove the extra ImageView and use the one built in UIButton
  • Centered the contents of AuthButton
  • Replaced the Google icon for one without blue borders
  • Title-cased the providers names
  • Used "Sign in with ..." for both login and signup

Before

Simulator Screen Shot - iPhone 11 - 2020-02-14 at 14 30 58

After

Simulator Screen Shot - iPhone 11 - 2020-02-14 at 14 04 43

References

auth0/lock#1801

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket added this to the vNext milestone Feb 14, 2020
@Widcket Widcket requested a review from a team February 14, 2020 17:36
@Widcket Widcket changed the title Update AuthButton to use SIWA-like style Updated AuthButton to use SIWA-like style Feb 14, 2020
@Widcket Widcket changed the title Updated AuthButton to use SIWA-like style Updated AuthButton style Feb 14, 2020
@Widcket Widcket changed the title Updated AuthButton style Updated AuthButton style [SDK-1361] Feb 14, 2020
@Widcket Widcket changed the title Updated AuthButton style [SDK-1361] Updated AuthButton style [SDK-1376] Feb 14, 2020
Copy link
Contributor

@joshcanhelp joshcanhelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clear, focused, and detailed-oriented PR here ... nice work! Main comment is about constants/enums for the network names and maybe the additive text as well, like "Sign in with" ... seems like a good candidate to define once and use multiple times.

Only other thing was a question about how this works ... this Lock form is loading within an application, correct? This is not displayed in a browser or anything?

Nothing blocking here 👍

@Widcket Widcket merged commit 7d6c774 into master Feb 14, 2020
@Widcket Widcket deleted the feature/button-style branch February 14, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants