Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AuthButton style to match Lock.js [SDK-1376] #600

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Update AuthButton style to match Lock.js [SDK-1376] #600

merged 1 commit into from
Mar 2, 2020

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Mar 2, 2020 •
edited
Loading

Changes

Updated AuthButton to match the new Lock.js style, that was in turn updated to prevent App Store rejections (due to the look of the SIWA button).

  • Refactored the layout of AuthButton to re-add the original ImageView
  • Left-aligned the button text
  • Set the border width to 1
  • Updated the tests

Simulator Screen Shot - iPhone 11 - 2020-03-02 at 10 36 04

References

Testing

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language or why not

Checklist

@Widcket Widcket requested a review from a team March 2, 2020 13:50
@Widcket Widcket added this to the vNext milestone Mar 2, 2020
@Widcket Widcket changed the title Update AuthButton style to match Lock.js Update AuthButton style to match Lock.js [SDK-1376] Mar 2, 2020
@stevehobbsdev
Copy link

@Widcket Can we see a preview of the login tab as well please?

@Widcket
Copy link
Contributor Author

Widcket commented Mar 2, 2020

@stevehobbsdev sure

Simulator Screen Shot - iPhone 11 - 2020-03-02 at 11 30 18

stevehobbsdev
stevehobbsdev approved these changes Mar 2, 2020
View reviewed changes
Copy link

@stevehobbsdev stevehobbsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Widcket Widcket merged commit 4a5117f into master Mar 2, 2020
@Widcket Widcket deleted the feature/button-style-compliance branch March 2, 2020 14:58
@Widcket Widcket mentioned this pull request Mar 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

Assignees
No one assigned
Labels
CH: Changed review:small Small review
Projects
None yet
Milestone
2.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Widcket @stevehobbsdev