Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade react-router-dom to v6 #2117

Merged
merged 8 commits into from
Jun 22, 2022
Merged

Upgrade react-router-dom to v6 #2117

merged 8 commits into from
Jun 22, 2022

Conversation

andychow326
Copy link
Contributor

ref #1945

@andychow326 andychow326 linked an issue Jun 16, 2022 that may be closed by this pull request
Upgrade react-router-dom to v6 #1945
Closed
louischan-oursky
louischan-oursky reviewed Jun 16, 2022
View reviewed changes
Copy link
Collaborator

@louischan-oursky louischan-oursky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Breadcumb does not work. For example, UserDetails to Users
  • AnonymousUserScreen: The apps link does not work
  • ApplicationsScreen: The custom domains link does not work

Please review all existing static links or navigate calls.

@louischan-oursky
Copy link
Collaborator

@andychow326

ApplicationsScreen: The custom domains link does not work

For example this still does not work. Please check the validity of existing links.

@louischan-oursky
Copy link
Collaborator

In case you missed my last comment

@andychow326 andychow326 force-pushed the 1945-upgrade-react-router-dom branch from 0de726e to 1201681 Compare June 21, 2022 07:44
@andychow326 andychow326 force-pushed the 1945-upgrade-react-router-dom branch from 1201681 to 1584319 Compare June 21, 2022 08:54
@louischan-oursky
Copy link
Collaborator

Change the links in ScreenNav to start with ./

@louischan-oursky louischan-oursky merged commit 9ecdc36 into authgear:master Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louischan-oursky louischan-oursky louischan-oursky left review comments

Assignees

@louischan-oursky louischan-oursky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade react-router-dom to v6
2 participants
@andychow326 @louischan-oursky