Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react-router-dom to v6 #2117

Merged
merged 8 commits into from
Jun 22, 2022
Merged

Upgrade react-router-dom to v6 #2117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
34730ea
Upgrade react-router-dom to v6
andychow326 Jun 16, 2022
b78cc78
Introduce custom useBlocker hook
andychow326 Jun 16, 2022
993cbbb
Refactor imports from react-router to react-router-dom
andychow326 Jun 16, 2022
0849e0d
Remove custom Route component
andychow326 Jun 16, 2022
2087837
Add type for data generated by useParams()
andychow326 Jun 17, 2022
4383576
Convert Routes structure to tree
andychow326 Jun 17, 2022
1584319
Correct url link
andychow326 Jun 21, 2022
71a8652
Correct ScreenNav url
andychow326 Jun 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,10 @@ otherwise, `npm run gentype` will fail.

@monaco-editor/react>=4 is slow in our usage. We need to adjust how we use it when we upgrade.

react-router-dom>6.0.0-beta.0 introduces a lot of breaking changes. It is better to wait for the RC version.
As `useBlocker` is removed since react-router-domv6.0.0-beta.7 and have no promise which version will
come back, we introduce the custom `useBlocker` hook by referencing the last commit which this hook
still exist.
See [https://github.com/remix-run/react-router/commit/256cad70d3fd4500b1abcfea66f3ee622fb90874](https://github.com/remix-run/react-router/commit/256cad70d3fd4500b1abcfea66f3ee622fb90874)

When Parcel cannot resolve nodejs globals such as `process` and `Buffer`,
it installs them for us.
Expand Down
40 changes: 19 additions & 21 deletions portal/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion portal/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
"react-code-blocks": "0.0.9-0",
"react-dom": "17.0.2",
"react-helmet-async": "1.2.2",
"react-router-dom": "6.0.0-beta.0",
"react-router-dom": "6.3.0",
"tzdata": "1.0.29",
"uuid": "8.3.2",
"zxcvbn": "4.4.2"
Expand Down
Loading