fix small typo in signinCallback doc in UserManager.ts #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
signinCallback documentation seemed to have been copy/pasted from signoutCallback leading to a confusing doc.
pamapa
approved these changes
Jun 12, 2024
|
thanks for contributing |
alexandresoro
pushed a commit
to alexandresoro/ouca
that referenced
this pull request
Oct 6, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [oidc-client-ts](https://github.com/authts/oidc-client-ts) | dependencies | minor | [`3.0.1` -> `3.1.0`](https://renovatebot.com/diffs/npm/oidc-client-ts/3.0.1/3.1.0) | --- ### Release Notes <details> <summary>authts/oidc-client-ts (oidc-client-ts)</summary> ### [`v3.1.0`](https://github.com/authts/oidc-client-ts/releases/tag/v3.1.0) [Compare Source](authts/oidc-client-ts@v3.0.1...v3.1.0) oidc-client-ts v3.1.0 is a minor release. No longer using `crypto-js` package, but built-in browser [crypto.subtle](https://developer.mozilla.org/en-US/docs/Web/API/Crypto/subtle) module. Crypto.subtle is available only in [secure contexts](https://developer.mozilla.org/en-US/docs/Web/Security/Secure_Contexts) (HTTPS). Also have a look into the [migration](https://github.com/authts/oidc-client-ts/blob/main/docs/migration.md) info. #### Changelog: - Fixes: - [#​1666](authts/oidc-client-ts#1666): fix link in docs to issue - [#​1600](authts/oidc-client-ts#1600): updated docs about logger - [#​1589](authts/oidc-client-ts#1589): fix compiler error for target=ES2022 - [#​1539](authts/oidc-client-ts#1539): fix small typo in `signinCallback` doc in UserManager.ts - [#​1504](authts/oidc-client-ts#1504): typo in sample app config - [#​1490](authts/oidc-client-ts#1490): fix the return type of `signinCallback` - [#​1443](authts/oidc-client-ts#1443): fixes typos in docs - Features: - [#​1672](authts/oidc-client-ts#1672): make `signoutCallback` return signout response if request_type is so:r - [#​1626](authts/oidc-client-ts#1626): add `popupSignal` property to `signinPopup` and `signoutPop` - [#​1580](authts/oidc-client-ts#1580): add dpop docs - [#​1569](authts/oidc-client-ts#1569): add dpop nonce support - [#​1457](authts/oidc-client-ts#1457): add extra headers - [#​1461](authts/oidc-client-ts#1461): add demonstrating proof of possession - [#​1430](authts/oidc-client-ts#1430): add global `requestTimeoutInSeconds` setting - [#​1405](authts/oidc-client-ts#1405): allow using default scopes from authorization server thanks to [@​klues](https://github.com/klues), [@​smujmaiku](https://github.com/smujmaiku), [@​mftruso](https://github.com/mftruso), [@​peetck](https://github.com/peetck), [@​dbfr3qs](https://github.com/dbfr3qs), [@​mottykohn](https://github.com/mottykohn), [@​noshiro-pf](https://github.com/noshiro-pf), [@​dbfr3qs](https://github.com/dbfr3qs), [@​grjan7](https://github.com/grjan7) and [@​natergj](https://github.com/natergj) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMDkuMCIsInVwZGF0ZWRJblZlciI6IjM4LjEwOS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/191 Reviewed-by: Alexandre Soro <[email protected]> Co-authored-by: renovate <[email protected]> Co-committed-by: renovate <[email protected]>
alexandresoro
pushed a commit
to alexandresoro/ouca
that referenced
this pull request
Oct 7, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [oidc-client-ts](https://github.com/authts/oidc-client-ts) | dependencies | minor | [`3.0.1` -> `3.1.0`](https://renovatebot.com/diffs/npm/oidc-client-ts/3.0.1/3.1.0) | --- ### Release Notes <details> <summary>authts/oidc-client-ts (oidc-client-ts)</summary> ### [`v3.1.0`](https://github.com/authts/oidc-client-ts/releases/tag/v3.1.0) [Compare Source](authts/oidc-client-ts@v3.0.1...v3.1.0) oidc-client-ts v3.1.0 is a minor release. No longer using `crypto-js` package, but built-in browser [crypto.subtle](https://developer.mozilla.org/en-US/docs/Web/API/Crypto/subtle) module. Crypto.subtle is available only in [secure contexts](https://developer.mozilla.org/en-US/docs/Web/Security/Secure_Contexts) (HTTPS). Also have a look into the [migration](https://github.com/authts/oidc-client-ts/blob/main/docs/migration.md) info. #### Changelog: - Fixes: - [#​1666](authts/oidc-client-ts#1666): fix link in docs to issue - [#​1600](authts/oidc-client-ts#1600): updated docs about logger - [#​1589](authts/oidc-client-ts#1589): fix compiler error for target=ES2022 - [#​1539](authts/oidc-client-ts#1539): fix small typo in `signinCallback` doc in UserManager.ts - [#​1504](authts/oidc-client-ts#1504): typo in sample app config - [#​1490](authts/oidc-client-ts#1490): fix the return type of `signinCallback` - [#​1443](authts/oidc-client-ts#1443): fixes typos in docs - Features: - [#​1672](authts/oidc-client-ts#1672): make `signoutCallback` return signout response if request_type is so:r - [#​1626](authts/oidc-client-ts#1626): add `popupSignal` property to `signinPopup` and `signoutPop` - [#​1580](authts/oidc-client-ts#1580): add dpop docs - [#​1569](authts/oidc-client-ts#1569): add dpop nonce support - [#​1457](authts/oidc-client-ts#1457): add extra headers - [#​1461](authts/oidc-client-ts#1461): add demonstrating proof of possession - [#​1430](authts/oidc-client-ts#1430): add global `requestTimeoutInSeconds` setting - [#​1405](authts/oidc-client-ts#1405): allow using default scopes from authorization server thanks to [@​klues](https://github.com/klues), [@​smujmaiku](https://github.com/smujmaiku), [@​mftruso](https://github.com/mftruso), [@​peetck](https://github.com/peetck), [@​dbfr3qs](https://github.com/dbfr3qs), [@​mottykohn](https://github.com/mottykohn), [@​noshiro-pf](https://github.com/noshiro-pf), [@​dbfr3qs](https://github.com/dbfr3qs), [@​grjan7](https://github.com/grjan7) and [@​natergj](https://github.com/natergj) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMTAuMiIsInVwZGF0ZWRJblZlciI6IjM4LjExMC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/196 Reviewed-by: Alexandre Soro <[email protected]> Co-authored-by: renovate <[email protected]> Co-committed-by: renovate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
signinCallback documentation seemed to have been copy/pasted from signoutCallback leading to a confusing doc.
Closes/fixes #issue
Checklist