Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup Abort Signals #1626

Merged
merged 6 commits into from
Aug 20, 2024
Merged

Popup Abort Signals #1626

merged 6 commits into from
Aug 20, 2024

Conversation

smujmaiku
Copy link
Contributor

@smujmaiku smujmaiku commented Aug 17, 2024

Closes: #1625

  • Adds popupSignal property to signinPopup and signoutPop methods to cancel windows similar to fetch signal

Checklist

  • This PR makes changes to the public API
  • I have included links for closing relevant issue numbers

@smujmaiku smujmaiku changed the title Draft: 1625 abort popup Draft: 1625 Abort Popup Aug 17, 2024
@smujmaiku smujmaiku changed the title Draft: 1625 Abort Popup 1625 Abort Popup Aug 17, 2024
@smujmaiku smujmaiku changed the title 1625 Abort Popup 1625 Popup Abort Signals Aug 17, 2024
@pamapa pamapa changed the title 1625 Popup Abort Signals Popup Abort Signals Aug 20, 2024
@pamapa pamapa added this to the 3.1.0 milestone Aug 20, 2024
@pamapa pamapa merged commit ad05ded into authts:main Aug 20, 2024
2 checks passed
@pamapa
Copy link
Member

pamapa commented Aug 20, 2024

thanks for contributing

alexandresoro pushed a commit to alexandresoro/ouca-backend that referenced this pull request Oct 6, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [oidc-client-ts](https://github.com/authts/oidc-client-ts) | dependencies | minor | [`3.0.1` -> `3.1.0`](https://renovatebot.com/diffs/npm/oidc-client-ts/3.0.1/3.1.0) |

---

### Release Notes

<details>
<summary>authts/oidc-client-ts (oidc-client-ts)</summary>

### [`v3.1.0`](https://github.com/authts/oidc-client-ts/releases/tag/v3.1.0)

[Compare Source](authts/oidc-client-ts@v3.0.1...v3.1.0)

oidc-client-ts v3.1.0 is a minor release.

No longer using `crypto-js` package, but built-in browser [crypto.subtle](https://developer.mozilla.org/en-US/docs/Web/API/Crypto/subtle) module. Crypto.subtle is available only in [secure contexts](https://developer.mozilla.org/en-US/docs/Web/Security/Secure_Contexts) (HTTPS). Also have a look into the [migration](https://github.com/authts/oidc-client-ts/blob/main/docs/migration.md) info.

#### Changelog:

-   Fixes:
    -   [#&#8203;1666](authts/oidc-client-ts#1666): fix link in docs to issue
    -   [#&#8203;1600](authts/oidc-client-ts#1600): updated docs about logger
    -   [#&#8203;1589](authts/oidc-client-ts#1589): fix compiler error for target=ES2022
    -   [#&#8203;1539](authts/oidc-client-ts#1539): fix small typo in `signinCallback` doc in UserManager.ts
    -   [#&#8203;1504](authts/oidc-client-ts#1504): typo in sample app config
    -   [#&#8203;1490](authts/oidc-client-ts#1490): fix the return type of `signinCallback`
    -   [#&#8203;1443](authts/oidc-client-ts#1443): fixes typos in docs
-   Features:
    -   [#&#8203;1672](authts/oidc-client-ts#1672): make `signoutCallback` return signout response if request_type is so:r
    -   [#&#8203;1626](authts/oidc-client-ts#1626): add `popupSignal` property to `signinPopup` and `signoutPop`
    -   [#&#8203;1580](authts/oidc-client-ts#1580): add dpop docs
    -   [#&#8203;1569](authts/oidc-client-ts#1569): add dpop nonce support
    -   [#&#8203;1457](authts/oidc-client-ts#1457): add extra headers
    -   [#&#8203;1461](authts/oidc-client-ts#1461): add demonstrating proof of possession
    -   [#&#8203;1430](authts/oidc-client-ts#1430): add global `requestTimeoutInSeconds` setting
    -   [#&#8203;1405](authts/oidc-client-ts#1405): allow using default scopes from authorization server

thanks to [@&#8203;klues](https://github.com/klues), [@&#8203;smujmaiku](https://github.com/smujmaiku), [@&#8203;mftruso](https://github.com/mftruso), [@&#8203;peetck](https://github.com/peetck), [@&#8203;dbfr3qs](https://github.com/dbfr3qs), [@&#8203;mottykohn](https://github.com/mottykohn), [@&#8203;noshiro-pf](https://github.com/noshiro-pf), [@&#8203;dbfr3qs](https://github.com/dbfr3qs), [@&#8203;grjan7](https://github.com/grjan7) and [@&#8203;natergj](https://github.com/natergj)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMDkuMCIsInVwZGF0ZWRJblZlciI6IjM4LjEwOS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/191
Reviewed-by: Alexandre Soro <[email protected]>
Co-authored-by: renovate <[email protected]>
Co-committed-by: renovate <[email protected]>
alexandresoro pushed a commit to alexandresoro/ouca-backend that referenced this pull request Oct 7, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [oidc-client-ts](https://github.com/authts/oidc-client-ts) | dependencies | minor | [`3.0.1` -> `3.1.0`](https://renovatebot.com/diffs/npm/oidc-client-ts/3.0.1/3.1.0) |

---

### Release Notes

<details>
<summary>authts/oidc-client-ts (oidc-client-ts)</summary>

### [`v3.1.0`](https://github.com/authts/oidc-client-ts/releases/tag/v3.1.0)

[Compare Source](authts/oidc-client-ts@v3.0.1...v3.1.0)

oidc-client-ts v3.1.0 is a minor release.

No longer using `crypto-js` package, but built-in browser [crypto.subtle](https://developer.mozilla.org/en-US/docs/Web/API/Crypto/subtle) module. Crypto.subtle is available only in [secure contexts](https://developer.mozilla.org/en-US/docs/Web/Security/Secure_Contexts) (HTTPS). Also have a look into the [migration](https://github.com/authts/oidc-client-ts/blob/main/docs/migration.md) info.

#### Changelog:

-   Fixes:
    -   [#&#8203;1666](authts/oidc-client-ts#1666): fix link in docs to issue
    -   [#&#8203;1600](authts/oidc-client-ts#1600): updated docs about logger
    -   [#&#8203;1589](authts/oidc-client-ts#1589): fix compiler error for target=ES2022
    -   [#&#8203;1539](authts/oidc-client-ts#1539): fix small typo in `signinCallback` doc in UserManager.ts
    -   [#&#8203;1504](authts/oidc-client-ts#1504): typo in sample app config
    -   [#&#8203;1490](authts/oidc-client-ts#1490): fix the return type of `signinCallback`
    -   [#&#8203;1443](authts/oidc-client-ts#1443): fixes typos in docs
-   Features:
    -   [#&#8203;1672](authts/oidc-client-ts#1672): make `signoutCallback` return signout response if request_type is so:r
    -   [#&#8203;1626](authts/oidc-client-ts#1626): add `popupSignal` property to `signinPopup` and `signoutPop`
    -   [#&#8203;1580](authts/oidc-client-ts#1580): add dpop docs
    -   [#&#8203;1569](authts/oidc-client-ts#1569): add dpop nonce support
    -   [#&#8203;1457](authts/oidc-client-ts#1457): add extra headers
    -   [#&#8203;1461](authts/oidc-client-ts#1461): add demonstrating proof of possession
    -   [#&#8203;1430](authts/oidc-client-ts#1430): add global `requestTimeoutInSeconds` setting
    -   [#&#8203;1405](authts/oidc-client-ts#1405): allow using default scopes from authorization server

thanks to [@&#8203;klues](https://github.com/klues), [@&#8203;smujmaiku](https://github.com/smujmaiku), [@&#8203;mftruso](https://github.com/mftruso), [@&#8203;peetck](https://github.com/peetck), [@&#8203;dbfr3qs](https://github.com/dbfr3qs), [@&#8203;mottykohn](https://github.com/mottykohn), [@&#8203;noshiro-pf](https://github.com/noshiro-pf), [@&#8203;dbfr3qs](https://github.com/dbfr3qs), [@&#8203;grjan7](https://github.com/grjan7) and [@&#8203;natergj](https://github.com/natergj)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMTAuMiIsInVwZGF0ZWRJblZlciI6IjM4LjExMC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/196
Reviewed-by: Alexandre Soro <[email protected]>
Co-authored-by: renovate <[email protected]>
Co-committed-by: renovate <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Canceling a Popup From the Parent
2 participants