Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update machine learning models download intructions #589

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Jul 11, 2024

Description

  • To Update machine learning models download instruction for updated models and new added models.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@badai-nguyen badai-nguyen added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Jul 11, 2024
esteve
esteve previously requested changes Jul 12, 2024
docs/models/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@badai-nguyen
Copy link
Contributor Author

@esteve @mitsudome-r
Since current download instructions is duplicated with autoware artifacts download instruction, as internal discussion with @kminoda and @miursh we would like to replace by reference link to reduce the maintain costs and ensure users are always directed to the latest models.
So I made update at commit e22939b
Could you review this PR again?

Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review 🙏

docs/models/index.md Outdated Show resolved Hide resolved
@esteve esteve dismissed their stale review July 22, 2024 06:21

Won't be able to review this PR the next few days

Signed-off-by: badai-nguyen <[email protected]>
@badai-nguyen badai-nguyen merged commit d7a9d63 into autowarefoundation:main Jul 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants