Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_tensorrt_yolox): add schema for autoware_tensorrt_yolox #10047

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

vish0012
Copy link
Contributor

Description

Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the autoware_tensorrt_yolox package.

  • create json schema

Related links

Parent Issue:

  • Link

How was this PR tested?

  • colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to autoware_tensorrt_yolox
  • ros2 launch launch/autoware_tensorrt_yolox.launch.xml

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Jan 30, 2025
Copy link

github-actions bot commented Jan 30, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@ktro2828 ktro2828 changed the title feat(autoware_tensorrt_yolox):Add schema for autoware_tensorrt_yolox feat(autoware_tensorrt_yolox): add schema for autoware_tensorrt_yolox Jan 30, 2025
@ktro2828 ktro2828 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.76%. Comparing base (ddfacd3) to head (babfe3b).
Report is 286 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10047   +/-   ##
=======================================
  Coverage   29.76%   29.76%           
=======================================
  Files        1444     1444           
  Lines      108686   108681    -5     
  Branches    42664    42665    +1     
=======================================
  Hits        32352    32352           
+ Misses      73150    73145    -5     
  Partials     3184     3184           
Flag Coverage Δ *Carryforward flag
differential-cuda 0.00% <ø> (?)
total 29.77% <ø> (+<0.01%) ⬆️ Carriedforward from ba32446

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

update min and max value in read file for "score_threshold"
Copy link
Contributor Author

@vish0012 vish0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update min and max value in read file for "score_threshold"

update min and max value in read file for "nms_threshold"
Copy link
Contributor Author

@vish0012 vish0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update min and max value in read file for "nms_threshold"

Copy link
Contributor

@ktro2828 ktro2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

2 participants