Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(goal_planner): resample path interval for lane departure check accuracy #10058

Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jan 31, 2025

Description

currently the parking path point interval for lane departure check is center_line_path_interval: 1.0
depending on resampled points sometimes departure can not be detected especialy cureve lane.

(footrpint in this image is not the exact path used for lane departure check. this is behavior path output.)

image

this is just workaround but in this PR, resample path interval for lane departure check accuracy.

todo: Implement lane departure detection that does not depend on the footprint

Related links

Parent Issue:

  • Link

How was this PR tested?

psim

2025/02/03 https://evaluation.tier4.jp/evaluation/reports/71aaf71c-79ae-5e67-a543-cef7922ab219/?project_id=prd_jt
2025/02/03 https://evaluation.tier4.jp/evaluation/reports/df5389ba-1355-5c2a-a221-bc9f9dfed558/?project_id=prd_jt

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 31, 2025
Copy link

github-actions bot commented Jan 31, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 26.76%. Comparing base (1e2f71b) to head (15218ba).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...r_module/src/pull_over_planner/shift_pull_over.cpp 0.00% 2 Missing ⚠️
...dule/src/pull_over_planner/geometric_pull_over.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10058      +/-   ##
==========================================
- Coverage   26.77%   26.76%   -0.02%     
==========================================
  Files        1416     1418       +2     
  Lines      108454   108496      +42     
  Branches    41706    41703       -3     
==========================================
  Hits        29035    29035              
- Misses      76548    76590      +42     
  Partials     2871     2871              
Flag Coverage Δ *Carryforward flag
differential 0.54% <0.00%> (?)
total 26.77% <ø> (+<0.01%) ⬆️ Carriedforward from 1e2f71b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 force-pushed the feat/imporve_lane_departure_accuracy branch 2 times, most recently from a91bc0b to 30e7b01 Compare February 5, 2025 09:21
@olikumar olikumar force-pushed the feat/imporve_lane_departure_accuracy branch from 30e7b01 to 8fe1b22 Compare February 12, 2025 04:22
@kosuke55 kosuke55 force-pushed the feat/imporve_lane_departure_accuracy branch from 8fe1b22 to 15218ba Compare February 17, 2025 01:46
@kosuke55 kosuke55 merged commit 5071753 into autowarefoundation:main Feb 17, 2025
33 of 34 checks passed
@kosuke55 kosuke55 deleted the feat/imporve_lane_departure_accuracy branch February 17, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants