Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add autoware_cuda_dependency_meta #10073

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

refactor: add autoware_cuda_dependency_meta #10073

wants to merge 10 commits into from
+39 −0

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Feb 5, 2025

Description

Added meta package that packages that depend on CUDA must depend on.

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:system System design and integration. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Feb 5, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@esteve esteve added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 5, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.86%. Comparing base (b795851) to head (d2f96cf).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10073      +/-   ##
==========================================
+ Coverage   26.83%   26.86%   +0.03%     
==========================================
  Files        1414     1418       +4     
  Lines      108290   108336      +46     
  Branches    41735    41740       +5     
==========================================
+ Hits        29056    29109      +53     
+ Misses      76351    76338      -13     
- Partials     2883     2889       +6
Flag Coverage Δ *Carryforward flag
differential 6.67% <ø> (?)
differential-cuda 5.88% <ø> (?)
total 26.83% <ø> (ø) Carriedforward from b795851

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esteve esteve force-pushed the add-cuda-deps branch 2 times, most recently from 305f2ac to 9e8c5a5 Compare February 12, 2025 11:59
@xmfcx
Copy link
Contributor

xmfcx commented Feb 18, 2025

Hi @esteve thanks for working on this task, is this ready for review? Are there any blockers?

esteve and others added 10 commits February 19, 2025 16:20
@esteve
build: add cuda dependency
de7d6a1 
Signed-off-by: Esteve Fernandez <[email protected]>
@esteve
build: add cuda_virtual package
77dffd2 
Signed-off-by: Esteve Fernandez <[email protected]>
@esteve
build: depend on cuda_virtual package
2f74959 
Signed-off-by: Esteve Fernandez <[email protected]>
@esteve
build: rename cuda_virtual to cuda
6d45a36 
Signed-off-by: Esteve Fernandez <[email protected]>
@esteve
build: fix CMake error
2a42e75 
Signed-off-by: Esteve Fernandez <[email protected]>
@esteve
build: use NONE to avoid setting up C and C++ in CMake
9cf5a06 
Signed-off-by: Esteve Fernandez <[email protected]>
@esteve
Removed duplicate cuda key
11aa3c4 
Signed-off-by: Esteve Fernandez <[email protected]>
@esteve
Rename to autoware_cuda_dependency_meta
269c091 
Signed-off-by: Esteve Fernandez <[email protected]>
@esteve
fix dependencies
6c7dacd 
Signed-off-by: Esteve Fernandez <[email protected]>
@esteve
fix project name
d2f96cf 
Signed-off-by: Esteve Fernandez <[email protected]>
@esteve
Copy link
Contributor Author

esteve commented Feb 19, 2025

@xmfcx I'm testing this in our buildfarm to make sure packages that depend on autoware_cuda_dependency_meta can be filtered out easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isamu-takagi isamu-takagi Awaiting requested review from isamu-takagi isamu-takagi will be requested when the pull request is marked ready for review isamu-takagi is a code owner

@sasakisasaki sasakisasaki Awaiting requested review from sasakisasaki sasakisasaki will be requested when the pull request is marked ready for review sasakisasaki is a code owner

@knzo25 knzo25 Awaiting requested review from knzo25 knzo25 will be requested when the pull request is marked ready for review knzo25 is a code owner

@mitsudome-r mitsudome-r Awaiting requested review from mitsudome-r mitsudome-r will be requested when the pull request is marked ready for review mitsudome-r is a code owner

@amadeuszsz amadeuszsz Awaiting requested review from amadeuszsz amadeuszsz will be requested when the pull request is marked ready for review amadeuszsz is a code owner

@manato manato Awaiting requested review from manato manato will be requested when the pull request is marked ready for review manato is a code owner

@MasatoSaeki MasatoSaeki Awaiting requested review from MasatoSaeki MasatoSaeki will be requested when the pull request is marked ready for review MasatoSaeki is a code owner

@Shin-kyoto Shin-kyoto Awaiting requested review from Shin-kyoto Shin-kyoto will be requested when the pull request is marked ready for review Shin-kyoto is a code owner

@miursh miursh Awaiting requested review from miursh miursh will be requested when the pull request is marked ready for review miursh is a code owner

@tzhong518 tzhong518 Awaiting requested review from tzhong518 tzhong518 will be requested when the pull request is marked ready for review tzhong518 is a code owner

@yukkysaito yukkysaito Awaiting requested review from yukkysaito yukkysaito will be requested when the pull request is marked ready for review yukkysaito is a code owner

@dan-dnn dan-dnn Awaiting requested review from dan-dnn dan-dnn will be requested when the pull request is marked ready for review dan-dnn is a code owner

@ktro2828 ktro2828 Awaiting requested review from ktro2828 ktro2828 will be requested when the pull request is marked ready for review ktro2828 is a code owner

@kminoda kminoda Awaiting requested review from kminoda kminoda will be requested when the pull request is marked ready for review kminoda is a code owner

@YoshiRi YoshiRi Awaiting requested review from YoshiRi YoshiRi will be requested when the pull request is marked ready for review YoshiRi is a code owner

@badai-nguyen badai-nguyen Awaiting requested review from badai-nguyen badai-nguyen will be requested when the pull request is marked ready for review badai-nguyen is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Software Working Group
Status: To Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esteve @xmfcx