Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refine maintainer list #10110

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: refine maintainer list #10110

wants to merge 2 commits into from
+11 −29

Conversation

miursh
Copy link
Contributor

@miursh miursh commented Feb 13, 2025 •
edited
Loading

Description

Remove Miura from the maintainer list.
Add Yoshi-san as the new maintainer.

Related links

autowarefoundation/autoware_launch#1328

How was this PR tested?

No test

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Feb 13, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 13, 2025
@miursh miursh changed the title chore: remove Miura from maintainer chore: refine maintainer list Feb 13, 2025
YoshiRi
YoshiRi approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for my part

@codecov Codecov
Copy link

codecov bot commented Feb 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.03%. Comparing base (3274695) to head (aca6983).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10110      +/-   ##
==========================================
- Coverage   28.03%   28.03%   -0.01%     
==========================================
  Files        1480     1483       +3     
  Lines      111211   111257      +46     
  Branches    43061    43070       +9     
==========================================
+ Hits        31183    31192       +9     
- Misses      77020    77055      +35     
- Partials     3008     3010       +2
Flag Coverage Δ *Carryforward flag
differential 25.26% <ø> (?)
differential-cuda 23.61% <ø> (?)
total 28.03% <ø> (-0.01%) ⬇️ Carriedforward from 26dcbd5

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ktro2828
ktro2828 approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@ktro2828 ktro2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

knzo25
knzo25 approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knzo25 knzo25 knzo25 approved these changes

@YoshiRi YoshiRi YoshiRi approved these changes

@kosuke55 kosuke55 kosuke55 approved these changes

@technolojin technolojin technolojin approved these changes

@ktro2828 ktro2828 ktro2828 approved these changes

@MasatoSaeki MasatoSaeki MasatoSaeki approved these changes

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3 taikitanaka3 is a code owner

@1222-takeshi 1222-takeshi Awaiting requested review from 1222-takeshi 1222-takeshi is a code owner

@scepter914 scepter914 Awaiting requested review from scepter914 scepter914 is a code owner

@amc-nu amc-nu Awaiting requested review from amc-nu amc-nu is a code owner

@badai-nguyen badai-nguyen Awaiting requested review from badai-nguyen badai-nguyen is a code owner

@drwnz drwnz Awaiting requested review from drwnz drwnz is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara is a code owner

@meliketanrikulu meliketanrikulu Awaiting requested review from meliketanrikulu meliketanrikulu is a code owner

@vividf vividf Awaiting requested review from vividf vividf is a code owner

@yukkysaito yukkysaito Awaiting requested review from yukkysaito yukkysaito is a code owner

@tzhong518 tzhong518 Awaiting requested review from tzhong518 tzhong518 is a code owner

@Shin-kyoto Shin-kyoto Awaiting requested review from Shin-kyoto Shin-kyoto is a code owner

@kminoda kminoda Awaiting requested review from kminoda kminoda is a code owner

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@sasakisasaki sasakisasaki Awaiting requested review from sasakisasaki sasakisasaki is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Software Working Group
Status: To Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@miursh @knzo25 @YoshiRi @kosuke55 @technolojin @ktro2828 @MasatoSaeki