Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(perception_utils): use slerp for orientation #1764

Merged

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Sep 1, 2022

Signed-off-by: yutaka [email protected]

Description

Since the predicted path can store the same points, it'll cause a serious problem when computing the orientation of each point by using two positions. In this PR, instead of using two points, I change the calculation by using spherical linear interpolation.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@purewater0901 purewater0901 marked this pull request as ready for review September 1, 2022 15:01
@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #1764 (3d4321b) into main (d38d66a) will increase coverage by 0.02%.
The diff coverage is 48.21%.

@@            Coverage Diff             @@
##             main    #1764      +/-   ##
==========================================
+ Coverage   10.35%   10.37%   +0.02%     
==========================================
  Files        1209     1210       +1     
  Lines       87338    87391      +53     
  Branches    20237    20275      +38     
==========================================
+ Hits         9043     9069      +26     
- Misses      68848    68849       +1     
- Partials     9447     9473      +26     
Flag Coverage Δ *Carryforward flag
differential 6.64% <49.05%> (?)
total 10.33% <33.33%> (ø) Carriedforward from d38d66a

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../include/perception_utils/predicted_path_utils.hpp 52.63% <0.00%> (ø)
...mmon/perception_utils/src/predicted_path_utils.cpp 49.05% <49.05%> (ø)
...tion/include/interpolation/interpolation_utils.hpp 54.83% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purewater0901 purewater0901 merged commit fd0d776 into autowarefoundation:main Sep 2, 2022
@purewater0901 purewater0901 deleted the fix/use-slerp-for-orientation branch September 2, 2022 01:45
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants