-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(perception_utils): use slerp for orientation #1764
feat(perception_utils): use slerp for orientation #1764
Conversation
Signed-off-by: yutaka <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1764 +/- ##
==========================================
+ Coverage 10.35% 10.37% +0.02%
==========================================
Files 1209 1210 +1
Lines 87338 87391 +53
Branches 20237 20275 +38
==========================================
+ Hits 9043 9069 +26
- Misses 68848 68849 +1
- Partials 9447 9473 +26
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: yutaka [email protected]
Description
Since the predicted path can store the same points, it'll cause a serious problem when computing the orientation of each point by using two positions. In this PR, instead of using two points, I change the calculation by using spherical linear interpolation.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.