Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): visualize pull over candidate path after approval #1848

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Sep 13, 2022

Description

visualize pull over candidate path after approval.

Screenshot from 2022-09-13 11-26-56

Screenshot from 2022-09-13 11-27-49

Related links

Tests performed

psim
(lane_departure doesn't work in shoulder_lane, so emergency is not a problem)

pull_over_candidate_path-2022-09-13_12.38.24.mp4

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #1848 (c4d69cb) into main (e28c169) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1848      +/-   ##
==========================================
- Coverage   10.46%   10.44%   -0.02%     
==========================================
  Files        1221     1221              
  Lines       87619    87779     +160     
  Branches    20420    20529     +109     
==========================================
  Hits         9165     9165              
- Misses      68977    69118     +141     
- Partials     9477     9496      +19     
Flag Coverage Δ *Carryforward flag
differential 1.28% <0.00%> (?)
total 10.44% <0.00%> (ø) Carriedforward from e28c169

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lanner/scene_module/pull_over/pull_over_module.hpp 0.00% <ø> (ø)
...er/src/scene_module/pull_over/pull_over_module.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kosuke55 kosuke55 merged commit 044f467 into autowarefoundation:main Sep 13, 2022
@kosuke55 kosuke55 deleted the feat/pull_over_candidate_path_after_approval branch September 13, 2022 07:20
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
1222-takeshi referenced this pull request in tier4/autoware.universe Oct 17, 2022
1222-takeshi referenced this pull request in tier4/autoware.universe Oct 18, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
kosuke55 referenced this pull request in tier4/autoware.universe Nov 10, 2022
kosuke55 referenced this pull request in tier4/autoware.universe Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants