Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(crosswalk): reduce processing time #2137

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Oct 24, 2022

Description

[TIER IV INTERNAL LINK] https://tier4.atlassian.net/browse/T4PB-20946

  • reduce crosswalk module's processing time

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Base: 10.76% // Head: 10.76% // No change to project coverage 👍

Coverage data is based on head (279859c) compared to base (279859c).
Patch has no changes to coverable lines.

❗ Current head 279859c differs from pull request most recent head 5f0cf6a. Consider uploading reports for the commit 5f0cf6a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2137   +/-   ##
=======================================
  Coverage   10.76%   10.76%           
=======================================
  Files        1186     1186           
  Lines       84749    84749           
  Branches    19827    19827           
=======================================
  Hits         9119     9119           
  Misses      65991    65991           
  Partials     9639     9639           
Flag Coverage Δ
total 10.73% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satoshi-ota satoshi-ota force-pushed the perf/reduce-crosswalk-processing-time branch from 90f2d8c to 5f0cf6a Compare October 25, 2022 00:34
@satoshi-ota
Copy link
Contributor Author

Evaluator Test 548/548 (All Green 👏 )
https://evaluation.tier4.jp/evaluation/reports/9cbde122-2f39-538e-bf1e-6d3c66d25c88?project_id=prd_jt

Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passed
LGTM

@satoshi-ota satoshi-ota merged commit d1b6e38 into autowarefoundation:main Oct 27, 2022
@satoshi-ota satoshi-ota deleted the perf/reduce-crosswalk-processing-time branch October 27, 2022 00:41
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Nov 10, 2022
* perf(crosswalk): use sparse resampled path

Signed-off-by: satoshi-ota <[email protected]>

* perf(crosswalk): create attention area all at once

Signed-off-by: satoshi-ota <[email protected]>

Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: tomoya.kimura <[email protected]>
tkimura4 added a commit to tier4/autoware.universe that referenced this pull request Nov 11, 2022
* perf(crosswalk): use sparse resampled path

Signed-off-by: satoshi-ota <[email protected]>

* perf(crosswalk): create attention area all at once

Signed-off-by: satoshi-ota <[email protected]>

Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: tomoya.kimura <[email protected]>

Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: tomoya.kimura <[email protected]>
Co-authored-by: Satoshi OTA <[email protected]>
tkimura4 added a commit to tier4/autoware.universe that referenced this pull request Nov 11, 2022
tkimura4 added a commit to tier4/autoware.universe that referenced this pull request Nov 11, 2022
)" (#179)

Revert "perf(crosswalk): reduce processing time (autowarefoundation#2137) (#175)"

This reverts commit e1a9339.
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
* perf(crosswalk): use sparse resampled path

Signed-off-by: satoshi-ota <[email protected]>

* perf(crosswalk): create attention area all at once

Signed-off-by: satoshi-ota <[email protected]>

Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants