Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add automatic PR labeler #2266

Merged
merged 8 commits into from
Nov 14, 2022
Merged

ci: add automatic PR labeler #2266

merged 8 commits into from
Nov 14, 2022

Conversation

shmpwk
Copy link
Contributor

@shmpwk shmpwk commented Nov 11, 2022

Signed-off-by: Shumpei Wakabayashi [email protected]

Description

This PR labels opening PR automatically according to label-path-mapping.yaml once a commit is pushed.
Labels helps to visualize what category the PR belongs to.

Related links

https://github.com/actions/labeler

Tests performed

I tested this in my private environment.

Notes for reviewers

  • The target files are almost all in this repository except LICENSE, NOTICE, *.repos
  • Once a PR is labeled, Labels won't disappear automatically even when the target files disappear at the future commit.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Nov 11, 2022
@shmpwk shmpwk changed the title feat(ci): add automatic pr labler feat(ci): add automatic pr labeler Nov 11, 2022
Signed-off-by: Shumpei Wakabayashi <[email protected]>
Signed-off-by: Shumpei Wakabayashi <[email protected]>
Signed-off-by: Shumpei Wakabayashi <[email protected]>
Copy link
Contributor

@kenji-miyake kenji-miyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks! Added small comments.

@kenji-miyake
Copy link
Contributor

@xmfcx Please comment if you have any thoughts.

@kenji-miyake kenji-miyake changed the title feat(ci): add automatic pr labeler ci: add automatic pr labeler Nov 11, 2022
@kenji-miyake kenji-miyake changed the title ci: add automatic pr labeler ci: add automatic PR labeler Nov 11, 2022
@shmpwk
Copy link
Contributor Author

shmpwk commented Nov 11, 2022

Thank you for fixing title.

Signed-off-by: Shumpei Wakabayashi <[email protected]>
Signed-off-by: Shumpei Wakabayashi <[email protected]>
Signed-off-by: Shumpei Wakabayashi <[email protected]>
Copy link
Contributor

@kenji-miyake kenji-miyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's okay to merge this and test it.

Signed-off-by: Shumpei Wakabayashi <[email protected]>
@shmpwk shmpwk merged commit 79c9e7a into main Nov 14, 2022
@shmpwk shmpwk deleted the feat/labeler branch November 14, 2022 01:57
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
* feat(ci): add automatic pr labeler

Signed-off-by: Shumpei Wakabayashi <[email protected]>

* fix: yaml lint

Signed-off-by: Shumpei Wakabayashi <[email protected]>

* chore: rename label

Signed-off-by: Shumpei Wakabayashi <[email protected]>

* chore: fix style and add more labeling files

Signed-off-by: Shumpei Wakabayashi <[email protected]>

* chore: change name and path

Signed-off-by: Shumpei Wakabayashi <[email protected]>

* chore: add pull_request_target

Signed-off-by: Shumpei Wakabayashi <[email protected]>

* chore: update version

Signed-off-by: Shumpei Wakabayashi <[email protected]>

* chore: add .rst

Signed-off-by: Shumpei Wakabayashi <[email protected]>

Signed-off-by: Shumpei Wakabayashi <[email protected]>
Signed-off-by: Kotaro Yoshimoto <[email protected]>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
* feat(ci): add automatic pr labeler

Signed-off-by: Shumpei Wakabayashi <[email protected]>

* fix: yaml lint

Signed-off-by: Shumpei Wakabayashi <[email protected]>

* chore: rename label

Signed-off-by: Shumpei Wakabayashi <[email protected]>

* chore: fix style and add more labeling files

Signed-off-by: Shumpei Wakabayashi <[email protected]>

* chore: change name and path

Signed-off-by: Shumpei Wakabayashi <[email protected]>

* chore: add pull_request_target

Signed-off-by: Shumpei Wakabayashi <[email protected]>

* chore: update version

Signed-off-by: Shumpei Wakabayashi <[email protected]>

* chore: add .rst

Signed-off-by: Shumpei Wakabayashi <[email protected]>

Signed-off-by: Shumpei Wakabayashi <[email protected]>
Signed-off-by: kminoda <[email protected]>
YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Jan 11, 2023
* feat(ci): add automatic pr labeler

Signed-off-by: Shumpei Wakabayashi <[email protected]>

* fix: yaml lint

Signed-off-by: Shumpei Wakabayashi <[email protected]>

* chore: rename label

Signed-off-by: Shumpei Wakabayashi <[email protected]>

* chore: fix style and add more labeling files

Signed-off-by: Shumpei Wakabayashi <[email protected]>

* chore: change name and path

Signed-off-by: Shumpei Wakabayashi <[email protected]>

* chore: add pull_request_target

Signed-off-by: Shumpei Wakabayashi <[email protected]>

* chore: update version

Signed-off-by: Shumpei Wakabayashi <[email protected]>

* chore: add .rst

Signed-off-by: Shumpei Wakabayashi <[email protected]>

Signed-off-by: Shumpei Wakabayashi <[email protected]>
Signed-off-by: yoshiri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants