build(traffic_light_fine_detector): remove download logic from CMake #4896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexey Panferov <[email protected]>
github-actions
bot
added
the
component:perception
esteve
added
the
run:build-and-test-differential
38 tasks
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4896 +/- ##
==========================================
- Coverage 15.81% 15.12% -0.69%
==========================================
Files 1581 1576 -5
Lines 109896 107499 -2397
Branches 34411 32769 -1642
==========================================
- Hits 17377 16259 -1118
- Misses 73393 73458 +65
+ Partials 19126 17782 -1344
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Alexey Panferov <[email protected]>
…ight_fine_detector' into remove_downloading_traffic_light_fine_detector
…c_light_fine_detector
…c_light_fine_detector
…c_light_fine_detector
4 tasks
lexavtanke
deleted the
remove_downloading_traffic_light_fine_detector
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #3137
According to discussion above remove downloading logic from building stage. For now It will be possible to download model files either by ansible or manually as explained in this PR
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.