-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(yabloc_pose_initializer): remove downloading logic from CMake #4905
build(yabloc_pose_initializer): remove downloading logic from CMake #4905
Conversation
Signed-off-by: Alexey Panferov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lexavtanke changes look good, thanks. Not sure if this PR is ready for review. Just some feedback, could you update the title and the commit message so that they follow the Autoware conventions? That is, "build(yabloc_pose_initializer): remove downloading logic from CMake" Thanks.
Signed-off-by: Alexey Panferov <[email protected]>
… remove_download_yabloc
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4905 +/- ##
==========================================
+ Coverage 14.99% 15.12% +0.13%
==========================================
Files 1608 1577 -31
Lines 111834 107182 -4652
Branches 34693 32676 -2017
==========================================
- Hits 16764 16215 -549
+ Misses 76336 73206 -3130
+ Partials 18734 17761 -973
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@lexavtanke is this PR now ready for review? |
Signed-off-by: Alexey Panferov <[email protected]>
… remove_download_yabloc
@KYabuuchi @Motsu-san could you have a look at this PR when you have a moment? Thanks. |
@lexavtanke Thank you for creating the PR. |
Signed-off-by: Alexey Panferov <[email protected]>
Signed-off-by: Alexey Panferov <[email protected]>
Signed-off-by: Alexey Panferov <[email protected]>
@KYabuuchi Thank you for your feedback. I've made updates to these files. Can you please review the PR then you will have time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding clear download instructions. This PR looks good to me 👍
Description
See #3137
According to discussion above remove downloading logic from building stage. For now it will be possible to download model files either by ansible or manually as explained in this PR
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.