Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lane_change): intersection check not considering size equal 1 #811

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

Signed-off-by: Muhammad Zulfaqar Azmi [email protected]

Description

Related issue: #810

During lane change, no lane following path is generated.

Screenshot from 2022-04-26 09-27-25

The actual behavior should be two path generated in this case, the first is the lane following trajectory, and another is the candidate path.

Screenshot from 2022-04-26 09-25-07

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 added type:bug Software flaws or errors. component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Apr 26, 2022
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 self-assigned this Apr 26, 2022
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 requested a review from rej55 April 26, 2022 01:08
@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #811 (261b26d) into main (80007ed) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff          @@
##            main    #811   +/-   ##
=====================================
  Coverage   9.66%   9.66%           
=====================================
  Files        908     908           
  Lines      56561   56561           
  Branches    6831    6831           
=====================================
  Hits        5465    5465           
  Misses     46593   46593           
  Partials    4503    4503           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 9.66% <0.00%> (ø) Carriedforward from 80007ed

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
planning/behavior_path_planner/src/utilities.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80007ed...261b26d. Read the comment docs.

Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rej55 rej55 merged commit 0b76783 into autowarefoundation:main Apr 26, 2022
rej55 added a commit that referenced this pull request Apr 26, 2022
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
miursh pushed a commit to miursh/autoware.universe that referenced this pull request Sep 13, 2023
…ation#811)

* chore: add workflow to merge beta branch to tier4 main

Signed-off-by: tomoya.kimura <[email protected]>

* fix: fix variable name

Signed-off-by: tomoya.kimura <[email protected]>

---------

Signed-off-by: tomoya.kimura <[email protected]>
ryuichi-maeda pushed a commit to sensefield/autoware.universe that referenced this pull request Jan 10, 2025
fix: install devel default

Signed-off-by: badai-nguyen <[email protected]>
iwatake2222 pushed a commit to iwatake2222/autoware.universe that referenced this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:bug Software flaws or errors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants