feat: use ansible to download ONNX files

[esteve]

Description

This PR uses Ansible to download ONNX files.

Fixes autowarefoundation/autoware.universe#3137

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[esteve]

@kenji-miyake I don't have much experience with Ansible, could you please have a look to make sure I'm on the right path? I'll add more tasks for more files. Thanks 🙏

[esteve]

@xmfcx @mitsudome-r this PR is now ready for review

[xmfcx]

Related: https://github.com/orgs/autowarefoundation/discussions/3649

[xmfcx]

Let the user pass the "autoware_data" folder directory to the ansible script. (ref: https://github.com/autowarefoundation/autoware/blob/main/setup-dev-env.sh ) (default: ~/autoware_data/ as suggested by @esteve )
Then ONNX files will be downloaded into:

.../autoware_data/package_name/map.pcd
.../autoware_data/package_name/map.josm ?
.../autoware_data/package_name/model1.onnx

Details in: https://github.com/orgs/autowarefoundation/discussions/3649#discussioncomment-6475228

Once this PR is tested and merged,

We can modify the launch files to point to these new files.

And we can proceed to remove existing cmake references.

[esteve]

@xmfcx this PR is ready for review now, I've added an option to specify the directory to download the files to and updated the ansible scripts to cover all the artifacts.

[xmfcx]

@lexavtanke could you review this please? If you have any questions, please don't hesitate to ask me or @esteve 🙏

[lexavtanke]

Downloading part works good for ONNX files. But I have mention that it can be confusing for the user that he need to create the structure inside the autoware_data folder by itself. May be it is better to add it to the ansible script. Cause then people use it for preparing the env in is a bit annoying then you need to start process again and again after you meet the errors like this

I also checked updates in documentation and didn't find the folder preparation in the current version.

[esteve]

@lexavtanke and I discussed this over Discord in private, I agree that this PR needs to be updated so that the folders for each package are created before downloading the models, ansible does not create folders automatically and needs to be told to create them beforehand.

[esteve]

@lexavtanke I've updated the PR to make sure that the directories are created per package before downloading the models, can you have another look? Thanks.

[lexavtanke]

@esteve Everything works good with creating folders but I experienced weird things during downloading some files:

Some checksums don't match in my case. I made suggestions in the review.

And now I noticed that ansible role named onnx. I think it can be confusing if it will be used to download artifacts for other packages. May be it is worth to change it to something like get_artfacts or just artifacts. What do you think?

[esteve]

@lexavtanke

May be it is worth to change it to something like get_artfacts or just artifacts. What do you think?

Good idea, artifacts sounds good to me.

[esteve]

@lexavtanke I've fixed all the ansible lint issues, could you have a look this PR again? Thanks.

[lexavtanke]

@esteve LGTM, thank you.

[lexavtanke]

@xmfcx I guess we need approval from you. Thanks

[esteve]

@xmfcx thanks 🙂