Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vim support. #151

Merged
merged 8 commits into from
Oct 25, 2017
Merged

Add vim support. #151

merged 8 commits into from
Oct 25, 2017

Conversation

autozimu
Copy link
Owner

No description provided.

@roxma
Copy link
Contributor

roxma commented Oct 25, 2017

hmm...

nvim_buf_add_highlight does not exist in vim-hug-neovim-rpc

And it seems this is a neovim-only feature.

@autozimu
Copy link
Owner Author

In that case, I can probably detect current feature and do not call the API for vim, which is somewhat expected. Even if I managed to get this work on vim, some of the features might never get to the state of support for neovim.

@roxma
Copy link
Contributor

roxma commented Oct 25, 2017

I can probably detect current feature and do not call the API for vim

I can add it into vim-hug-neovim-rpc, and it will simply ignore the error for now. I'll update the documentation for this.

This feature is hard to workaround. But it only affects the views, so ignoring the error should be just fine.

roxma added a commit to roxma/vim-hug-neovim-rpc that referenced this pull request Oct 25, 2017
@autozimu autozimu merged commit dec2f87 into master Oct 25, 2017
@autozimu autozimu mentioned this pull request Oct 25, 2017
@roxma
Copy link
Contributor

roxma commented Oct 26, 2017

Unfortunately I'm still having issue with completion with LanguageServer-php-neovim

screenshot_20171026_102946

screenshot_20171026_103035

These messages are forwarded from stderr of the process. But I'm not sure where it's coming from.

@autozimu
Copy link
Owner Author

I cannot reproduce it.

Can you provide min vimrc and each version numbers?

@roxma
Copy link
Contributor

roxma commented Oct 26, 2017

I'm debugging.

The error message forwarded by yarp is not well formatted. I'lll post detailed information when I fixed the message format.

roxma added a commit to roxma/vim-hug-neovim-rpc that referenced this pull request Oct 26, 2017
@roxma
Copy link
Contributor

roxma commented Oct 26, 2017

Unfortunately, due to vim's issue on handling the python None, I workaround this issue by converting it to empty string.

vim/vim#2246

No error anymore.

@autozimu
Copy link
Owner Author

👍

@autozimu autozimu deleted the vim branch October 28, 2017 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants