Have assertions return booleans

[novemberborn]

Spurred by conversation in #2449 and #1485 we'd like for our assertions to return booleans. true when they pass, false when they fail. This does not apply to the throws() and throwsAsync() assertions.

Failing assertions will fail the test, but do not throw exceptions. This means your test does not stop executing. Usually that's fine, but there are conditions where you're about to do something that uses a lot of resources, and it's already unnecessary. Returning booleans will help with this.

The assertions are defined here:

ava/lib/assert.js

Line 238 in 18aeac6

class Assertions {

The type definition should be updated to reflect the new return type:

ava/index.d.ts

Line 41 in 18aeac6

export interface Assertions {

Some tests should be added to (or existing test updated in) https://github.com/avajs/ava/blob/master/test-tap/assert.js.

[aviralch]

Hello,

can i work on this ?

[novemberborn]

@aviralch yea that'd be great, thanks!

[pmascheroni]

Hi, @novemberborn I am also attempting an update to this issue and wondering if I could be assigned to it too? Not sure if that is allowed, but I would like to work on this also.

Thanks

[novemberborn]

@pmascheroni let's give @aviralch a chance first.

[aviralch]

@novemberborn, @pmascheroni this is my first issue, I will try to do this and keep you updated by the end of of week.

[BARICISSE]

Hi, if no one is currently working on this and it is still open, i would like to contribute.

[novemberborn]

@aviralch what do you think?

[aviralch]

Yup, sure go ahead. I am currently in middle of exams but if you need to get in touch lmk.

[novemberborn]

Thank you @aviralch, and good luck!

[RahulKannan12]

Hi, is it done ?, if not I can make a try ! Please let me know 👍 I would like to contribute

[BARICISSE]

Hi @RahulKannan12, I am currently working on it.

[RahulKannan12]

Hi @BARICISSE , Okay great ! thanks for the information 👍

[HungryPandaBytes]

Hello is this ticket still open? If not, I would like to grab this!

[novemberborn]

@mzzlillieee yes go for it.

[jmarkham828]

@mzzlillieee @novemberborn Hey yo! :) I have a draft PR for this issue that I believe is almost there. @novemberborn need a little guidance on how to update the test file -- this is my first issue. Would you mind if I pushed up what I had if @mzzlillieee is busy?

[HungryPandaBytes]

@jmarkham828 No I don't mind. Something came up, so I won't be able to work on this issue until next week.

[jmarkham828]

@mzzlillieee awesome! @novemberborn would you mind adding me to this issue so I can push?

[novemberborn]

would you mind adding me to this issue so I can push?

@jmarkham828 sure, but you don't need to be assigned an issue to create a PR 😉

[rShar01]

Does this issue still a contributer?

[novemberborn]

@rShar01 this was picked up by @jmarkham828 quite recently, so maybe check in with them.

[jmarkham828]

Will work on this PR #2564 more this weekend -- took me a while to tie up some projects at work, but am free to work Saturday and Sunday! Like I said, @novemberborn, I wasn't quite sure how to update the test file, what do you think?

[adiSuper94]

@novemberborn , I'd like to take a crack at this issue. If @jmarkham828 is no longer active.

[novemberborn]

@adiSuper94 both you and @Davidmh93 have expressed an interest. And we haven't yet heard back from @jmarkham828 but that's OK. I think if either of you could take their commits and add on top of them, based on my feedback in #2564 that'd be great. And then you could help each other as well if need be. Does that sound all right?

[dmanit]

I'm unable to pick this one up now sorry

[shailenpatel1]

Can I work on this?

[novemberborn]

@shailenpatel1 maybe you could pick up where #2586 left off?

[novemberborn]

Merged in #2696.