[draft] feat: have assertions return booleans #2564
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| promise.then(() => { | ||
| lastPassed = true; | ||
| }, error => { | ||
| return promise.then(() => |
There was a problem hiding this comment.
Let's change this to an async function.
There was a problem hiding this comment.
Are you still spending time on this project? I'd like to setup a call to discuss the code if you're interested? Don't want to waste time trying to interpret the code would be much quicker for you to walk through it.
| }, error => { | ||
| return promise.then(() => | ||
| true | ||
| , error => { | ||
| lastFailure = error; |
There was a problem hiding this comment.
This should return false, no?
| }, | ||
| skip: () => {}, | ||
| experiments: {}, | ||
| experiments: { | ||
| likeAssertion: true |
There was a problem hiding this comment.
This experiment has been removed, the old line was fine 😉
This was referenced Sep 19, 2020
|
Closing in favor of #2586. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue: #2455, having assertions return booleans.