Return booleans indicating whether assertions passed

[jmarkham828]

Apologies for dropping this. I just finished university! 🥳

Hoping to still contribute to this awesome project. I picked up where this left off. I totally understand if this PR is closed, given that I left it hanging for a while, but wanted to give it another go at resolving #2455, since it doesn't look like #2586 is active any longer.

[jmarkham828]

@novemberborn Getting an error like this:

Error: Error loading ava.config.js: Not supported
    at loadJsConfig (/Users/johnmarkham/Desktop/ava/lib/load-config.js:33:23)

when trying to lint the files or check types (xo, tsd) to get the build green. Have you seen something like this before? Also not quite sure how to diagnose the failing type tests.

[novemberborn]

I don't see that XO error output in CI, maybe it's a case of outdated dependencies installed on your machine? There are a lot of other linting errors though.

There should be some easier to solve TypeScript errors, like SnapshotOptions being missing. A lot has changed recently, might just be that your older commits are trying to reintroduce some code that is no longer meant to be there.

[jmarkham828]

@novemberborn thanks for getting back to me. Weird... I have no diff with any packages, and no diff with any configuration files for xo, yet always get an error loading ava.config.js or ava.config.mjs locally...

[jmarkham828]

Nice. The solution was quite weird: I commented this out, then ran npx xo --fix <file> and it did the trick. Then even after uncommenting that line, xo did not throw an error anymore. Some weird setup bug maybe. 🤷

[novemberborn]

@jmarkham828 I've pushed some tweaks, notably in the tests to assert on the return values. The throws assertions shouldn't return booleans which I've also fixed.

Would you mind updating the documentation for the assertions that now return booleans?

[jmarkham828]

Thank you so much for the help, @novemberborn. 🙏

Separately, how could 64ad93e have caused the build to fail 🤔

[novemberborn]

Separately, how could 64ad93e have caused the build to fail 🤔

Just flakiness. A different run failed this time.