Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping assertions is changing in AVA 1.0 #187

Closed
novemberborn opened this issue Feb 11, 2018 · 2 comments · Fixed by #277
Closed

Skipping assertions is changing in AVA 1.0 #187

novemberborn opened this issue Feb 11, 2018 · 2 comments · Fixed by #277
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@novemberborn
Copy link
Member

novemberborn commented Feb 11, 2018

Issuehunt badges

avajs/ava#1696 changes assertion skipping from t.skip.true() to t.true.skip().

From searching the rule documentation this impacts no-skip-assert and use-t-well.

Interestingly enough it looks as if use-t-well has some support for t.true.skip() even though it never worked.

Note that t.skip() no longer exists.


Note: This issue has a bounty, so it's expected that you are an experienced programmer and that you give it your best effort if you intend to tackle this. Don't forget, if applicable, to add tests, docs (double-check for typos). And don't be sloppy. Review your own diff multiple times and try to find ways to improve and simplify your code. Instead of asking too many questions, present solutions. The point of an issue bounty is to reduce my workload, not give me more. Include a 🦄 in your PR description to indicate that you've read this. Thanks for helping out 🙌 - @sindresorhus


IssueHunt Summary

stroncium stroncium has been rewarded.

Backers (Total: $60.00)

Submitted pull Requests


Tips


IssueHunt has been backed by the following sponsors. Become a sponsor

@issuehunt-oss
Copy link

issuehunt-oss bot commented Sep 17, 2019

@issuehunt has funded $60.00 to this issue.


@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label Sep 17, 2019
stroncium added a commit to stroncium/eslint-plugin-ava that referenced this issue Sep 29, 2019
@issuehunt-oss
Copy link

issuehunt-oss bot commented Feb 26, 2020

@sindresorhus has rewarded $54.00 to @stroncium. See it on IssueHunt

  • 💰 Total deposit: $60.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $6.00

@issuehunt-oss issuehunt-oss bot added 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt and removed 💵 Funded on Issuehunt This issue has been funded on Issuehunt labels Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants