Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion methods auto correction for use-t-well rule #277

Merged
merged 8 commits into from
Feb 26, 2020

Conversation

stroncium
Copy link
Contributor

@stroncium stroncium commented Sep 28, 2019

Fixes #244

Simple breadth-first early terminating Levenshtein distance auto correcter for assertion methods.
Handles all samples from the issue and some more. (Some of earlier test cases have more suiting error messages and became fixable too.)

Fixes #187

Detects and fixes multiple skip and skip being not the last in chain.

NOTE: integration tests fail for some reason, but they fail even without this patch.
🦄


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


IssueHunt has been backed by the following sponsors. Become a sponsor

@stroncium stroncium changed the title Assertion methods auto correction for use-t-well rule, makes most misspells fixable Assertion methods auto correction for use-t-well rule Sep 29, 2019
@stroncium stroncium changed the title Assertion methods auto correction for use-t-well rule Assertion methods auto correction for use-t-well rule Sep 29, 2019
rules/use-t-well.js Outdated Show resolved Hide resolved
rules/use-t-well.js Outdated Show resolved Hide resolved
@stroncium
Copy link
Contributor Author

@sindresorhus Moved the correction code itself to micro-spelling-correcter(https://github.com/stroncium/micro-spelling-correcter) which packs it all together and provides simplest interface possible. No magic constants anymore.

NOTE: codecov fails for https://github.com/stroncium/micro-spelling-correcter for some reason atm, but coverage is 100%, will look into why it fails later.

@sindresorhus sindresorhus merged commit d9f9a49 into avajs:master Feb 26, 2020
@sindresorhus
Copy link
Member

Looks good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make use-t-well more auto-fixable Skipping assertions is changing in AVA 1.0
2 participants