Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use-t-well more auto-fixable #244

Closed
GMartigny opened this issue May 15, 2019 · 7 comments · Fixed by #277
Closed

Make use-t-well more auto-fixable #244

GMartigny opened this issue May 15, 2019 · 7 comments · Fixed by #277
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@GMartigny
Copy link
Contributor

GMartigny commented May 15, 2019

Issuehunt badges

When #229 is merged, use-t-well will be able to autofix falsey to falsy (a common misspell).

This can be expanded further by creating a small list of common misspells that can be autofixed (t.contxt, t.truthey, t.deepequal ...)
I don't know what's the limit to the size of that list. It could even be allowed to customize it with an option.


Note: This issue has a bounty, so it's expected that you are an experienced programmer and that you give it your best effort if you intend to tackle this. Don't forget, if applicable, to add tests, docs (double-check for typos). And don't be sloppy. Review your own diff multiple times and try to find ways to improve and simplify your code. Instead of asking too many questions, present solutions. The point of an issue bounty is to reduce my workload, not give me more. Include a 🦄 in your PR description to indicate that you've read this. Thanks for helping out 🙌 - @sindresorhus


IssueHunt Summary

stroncium stroncium has been rewarded.

Backers (Total: $60.00)

Submitted pull Requests


Tips


IssueHunt has been backed by the following sponsors. Become a sponsor

@sindresorhus
Copy link
Member

sindresorhus commented May 23, 2019

Sounds good. I don't think we need to make it customizable though. PR welcome.

@sindresorhus sindresorhus changed the title [Feature] More auto fixable on use-t-well Make use-t-well more auto-fixable May 23, 2019
@GMartigny
Copy link
Contributor Author

GMartigny commented May 23, 2019

If not customizable, we need to define a list of replacements that the plugin will care for.

Updated list here for convenience:

  • contxt => context
  • /deepequal/i => deepEqual
  • /notdeepEqual/i => notDeepEqual
  • throw => throws
  • notThrow => notThrows
  • /notthrows/i => notThrows
  • throwAsync => throwsAsync
  • /throwsasync/i => throwsAsync
  • notThrowAsync => notThrowsAsync
  • /notthrowsasync/i => notThrowsAsync
  • regexp => regex
  • /notregex/i => notRegex
  • notRegexp => notRegex

Any suggestion ?

@sindresorhus
Copy link
Member

Your list looks good. I can't think of anything else.

@GMartigny
Copy link
Contributor Author

I've just add regexp => regex for no particular reasons 🙄

@issuehunt-oss
Copy link

issuehunt-oss bot commented Sep 17, 2019

@issuehunt has funded $60.00 to this issue.


@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label Sep 17, 2019
@stroncium
Copy link
Contributor

@sindresorhus this inspired me to check my basic skills and I wrote simplistic auto correction module. It is able to fix all the mentioned corrections and some more. Should I add it?

@issuehunt-oss
Copy link

issuehunt-oss bot commented Feb 26, 2020

@sindresorhus has rewarded $54.00 to @stroncium. See it on IssueHunt

  • 💰 Total deposit: $60.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $6.00

@issuehunt-oss issuehunt-oss bot added 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt and removed 💵 Funded on Issuehunt This issue has been funded on Issuehunt labels Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants