Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Auto-play of some sections seems to break Ramp and causes player to disappear #5385

Closed
4 tasks
elynema opened this issue Sep 26, 2023 · 11 comments
Closed
4 tasks
Assignees
Labels

Comments

@elynema
Copy link
Contributor

elynema commented Sep 26, 2023

Describe the bug
When auto-play reaches the third section of this record, the media player disappears and does not play.

To Reproduce
Steps to reproduce the behavior, including the results:

  1. Go to https://avalon-dev.dlib.indiana.edu/media_objects/g158bh28p
  2. Select the 2nd section and let it play (you can skip ahead in the file)
  3. When it auto-advances to the third section, the media player disappears

Screenshots/Screen Recording
Private Zenhub Image

Environment (please complete the following information):

  • Device / platform: Mac laptop
  • OS: Mac OS Monterey
  • Browser: Chrome
  • [ x] avalon-dev
  • avalon-staging
  • mco-staging
  • mco-production
  • demo

Release:
7.7

@elynema elynema added the bug label Sep 26, 2023
@elynema
Copy link
Contributor Author

elynema commented Oct 4, 2023

Current Ramp build in Avalon does not auto-advance by default. This can't be tested until we add auto-advance behavior into media object manifests.

@elynema
Copy link
Contributor Author

elynema commented Oct 6, 2023

Timebox this investigation to a 2; may need to update points once we investigate.

@masaball
Copy link
Contributor

masaball commented Oct 18, 2023

Original bug on Avalon-dev is not reproducible on the example item because of changes to manifest generation. The player is still breaking but that is because there is an item-less canvas in the manifest now and we have not implemented the handling for that situation in Ramp yet.

Editing the manifest to remove the blank canvas and testing directly in Ramp did not result in the player disappearing but there was a console error related to a function attempting to set a start time from an undefined object. A fix for that error is being added by Ramp #270. Once that PR is merged and brought into Avalon, we can probably close this issue unless the behavior is encountered again.

@elynema
Copy link
Contributor Author

elynema commented Oct 19, 2023

We believe this is resolved, although the original example linked still has problems for a different reason. Moving to QA, although it may not be possible to fully QA. Test sample of media objects. Will need to re-create issue if we encounter the behavior again after this.

@elynema
Copy link
Contributor Author

elynema commented Oct 20, 2023

Let's hold on QA for this one while waiting for Ramp samvera-labs/ramp#263, which is in next sprint.

@elynema
Copy link
Contributor Author

elynema commented Nov 12, 2023

This should be ready for QA now.

@charumitraravi
Copy link
Contributor

The player disappearing issue seems to be resolved now. Although, I do find a number of items showing the following error:
Private Zenhub Image
Some other examples:
https://avalon-dev.dlib.indiana.edu/media_objects/8049g504g
https://avalon-dev.dlib.indiana.edu/media_objects/ng451h485

@elynema
Copy link
Contributor Author

elynema commented Nov 27, 2023

@cjcolvar See Charu's comment above for an example item that has the "failed to fetch manifest" error.

@elynema
Copy link
Contributor Author

elynema commented Dec 7, 2023

@charumitraravi Did you finish QA of this once the multiple sections issue was fixed on avalon-dev?

@charumitraravi
Copy link
Contributor

When I did QA for this item, there was no "failed to fetch manifest" issue due to multiple sections. I believe it happened a week after I tested this. Did you want me to retest this again now?

@elynema
Copy link
Contributor Author

elynema commented Dec 7, 2023

@charumitraravi, ah, so you were saying above that QA was completed. Presumably this specific item is giving errors because it is actually missing derivatives. I'll go ahead and close this.

@elynema elynema closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants