-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Auto-play of some sections seems to break Ramp and causes player to disappear #5385
Comments
Current Ramp build in Avalon does not auto-advance by default. This can't be tested until we add auto-advance behavior into media object manifests. |
Timebox this investigation to a 2; may need to update points once we investigate. |
Original bug on Avalon-dev is not reproducible on the example item because of changes to manifest generation. The player is still breaking but that is because there is an item-less canvas in the manifest now and we have not implemented the handling for that situation in Ramp yet. Editing the manifest to remove the blank canvas and testing directly in Ramp did not result in the player disappearing but there was a console error related to a function attempting to set a start time from an undefined object. A fix for that error is being added by Ramp #270. Once that PR is merged and brought into Avalon, we can probably close this issue unless the behavior is encountered again. |
We believe this is resolved, although the original example linked still has problems for a different reason. Moving to QA, although it may not be possible to fully QA. Test sample of media objects. Will need to re-create issue if we encounter the behavior again after this. |
Let's hold on QA for this one while waiting for Ramp samvera-labs/ramp#263, which is in next sprint. |
This should be ready for QA now. |
The player disappearing issue seems to be resolved now. Although, I do find a number of items showing the following error: |
@cjcolvar See Charu's comment above for an example item that has the "failed to fetch manifest" error. |
@charumitraravi Did you finish QA of this once the multiple sections issue was fixed on avalon-dev? |
When I did QA for this item, there was no "failed to fetch manifest" issue due to multiple sections. I believe it happened a week after I tested this. Did you want me to retest this again now? |
@charumitraravi, ah, so you were saying above that QA was completed. Presumably this specific item is giving errors because it is actually missing derivatives. I'll go ahead and close this. |
Describe the bug
When auto-play reaches the third section of this record, the media player disappears and does not play.
To Reproduce
Steps to reproduce the behavior, including the results:
Screenshots/Screen Recording
Private Zenhub Image
Environment (please complete the following information):
Release:
7.7
The text was updated successfully, but these errors were encountered: