-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] product_product_stock_forecast: New object "Product stock forec… #762
[ADD] product_product_stock_forecast: New object "Product stock forec… #762
Conversation
Codecov Report
@@ Coverage Diff @@
## 12.0 #762 +/- ##
==========================================
+ Coverage 96.04% 96.41% +0.36%
==========================================
Files 33 36 +3
Lines 734 837 +103
==========================================
+ Hits 705 807 +102
- Misses 29 30 +1
Continue to review full report at Codecov.
|
@avanzosc/developers ... review please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debería de llamarse algo así como stock_forecast, si ya existe stock_product_forecast
2ff39b4
to
17897d5
Compare
Renombrado el módulo como me ha solicitado @oihane . Eskerrik asko. |
Renombrado el módulo. Eskerrik asko.
17897d5
to
727e80f
Compare
stock_forecast/models/product.py
Outdated
|
||
def action_view_product_stock_forecast_from_template(self): | ||
self.ensure_one() | ||
self.env['product.product.stock.forecast']. _calc_qty_per_day( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hay un espacio entre '.' y el '_', hace bien la llamada a la función?
stock_forecast/models/product.py
Outdated
|
||
def action_view_product_stock_forecast_from_product(self): | ||
self.ensure_one() | ||
self.env['product.product.stock.forecast']. _calc_qty_per_day( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mismo espacio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aupa @Daniel-CA , realizada la mejora que me has solicitado. Lo bueno.... es que si funcionaba, llamaba a la función sin problemas. Lo raro también que no diera error de flake8
727e80f
to
bfb8ab5
Compare
…ast".