Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] product_product_stock_forecast: New object "Product stock forec… #762

Conversation

alfredoavanzosc
Copy link
Contributor

…ast".

@codecov
Copy link

codecov bot commented Aug 14, 2019

Codecov Report

Merging #762 into 12.0 will increase coverage by 0.36%.
The diff coverage is 99.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##             12.0     #762      +/-   ##
==========================================
+ Coverage   96.04%   96.41%   +0.36%     
==========================================
  Files          33       36       +3     
  Lines         734      837     +103     
==========================================
+ Hits          705      807     +102     
- Misses         29       30       +1
Impacted Files Coverage Δ
stock_forecast/models/sale_order.py 100% <100%> (ø)
stock_forecast/models/stock.py 100% <100%> (ø)
stock_forecast/models/product.py 98.61% <98.61%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ae344f...bfb8ab5. Read the comment docs.

@alfredoavanzosc
Copy link
Contributor Author

@avanzosc/developers ... review please

oihane
oihane previously requested changes Aug 14, 2019
Copy link
Contributor

@oihane oihane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debería de llamarse algo así como stock_forecast, si ya existe stock_product_forecast

@alfredoavanzosc alfredoavanzosc force-pushed the odoo-addons12-product-product_stock_forecast branch 2 times, most recently from 2ff39b4 to 17897d5 Compare August 14, 2019 13:23
@alfredoavanzosc
Copy link
Contributor Author

Renombrado el módulo como me ha solicitado @oihane . Eskerrik asko.


def action_view_product_stock_forecast_from_template(self):
self.ensure_one()
self.env['product.product.stock.forecast']. _calc_qty_per_day(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hay un espacio entre '.' y el '_', hace bien la llamada a la función?


def action_view_product_stock_forecast_from_product(self):
self.ensure_one()
self.env['product.product.stock.forecast']. _calc_qty_per_day(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mismo espacio

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aupa @Daniel-CA , realizada la mejora que me has solicitado. Lo bueno.... es que si funcionaba, llamaba a la función sin problemas. Lo raro también que no diera error de flake8

@oihane oihane added this to the 12.0 milestone Aug 29, 2019
@alfredoavanzosc alfredoavanzosc force-pushed the odoo-addons12-product-product_stock_forecast branch from 727e80f to bfb8ab5 Compare August 29, 2019 10:27
@alfredoavanzosc alfredoavanzosc merged commit 0f75674 into avanzosc:12.0 Sep 2, 2019
@alfredoavanzosc alfredoavanzosc deleted the odoo-addons12-product-product_stock_forecast branch September 2, 2019 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants