dtr bar display #108
Annotations
9 errors and 1 warning
Build:
BossMod/Autorotation/DTR.cs#L8
Provide an overridable implementation of Dispose(bool) on 'DTR' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
Build:
BossMod/Autorotation/DTR.cs#L23
Modify 'DTR.Dispose' so that it calls Dispose(true), then calls GC.SuppressFinalize on the current object instance ('this' or 'Me' in Visual Basic), and then returns (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
Build:
BossMod/Autorotation/DTR.cs#L42
In member BossMod.Autorotation.DTRPopup.DTRPopup(BossMod.Autorotation.RotationModuleManager), remove the underscores from parameter name _mgr (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707)
|
Build:
BossMod/Autorotation/DTR.cs#L13
'DTR' contains field '_popup' that is of IDisposable type 'DTRPopup', but it is never disposed. Change the Dispose method on 'DTR' to call Close or Dispose on this field. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2213)
|
Build:
BossMod/Autorotation/DTR.cs#L8
Provide an overridable implementation of Dispose(bool) on 'DTR' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
Build:
BossMod/Autorotation/DTR.cs#L23
Modify 'DTR.Dispose' so that it calls Dispose(true), then calls GC.SuppressFinalize on the current object instance ('this' or 'Me' in Visual Basic), and then returns (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
Build:
BossMod/Autorotation/DTR.cs#L42
In member BossMod.Autorotation.DTRPopup.DTRPopup(BossMod.Autorotation.RotationModuleManager), remove the underscores from parameter name _mgr (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707)
|
Build:
BossMod/Autorotation/DTR.cs#L13
'DTR' contains field '_popup' that is of IDisposable type 'DTRPopup', but it is never disposed. Change the Dispose method on 'DTR' to call Close or Dispose on this field. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2213)
|
Build
Process completed with exit code 1.
|
Build
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-dotnet@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|