test: add non-interactive init/pull in git-cloned project #11365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardfoyle
changed the title
edwardfoyle
commented
Nov 9, 2022
| /* eslint-disable func-style */ | ||
| /* eslint-disable @typescript-eslint/explicit-function-return-type */ | ||
| /* eslint-disable jsdoc/require-jsdoc */ | ||
| /* eslint-disable import/no-cycle */ |
There was a problem hiding this comment.
this file is minimal lint fixes after moving the isCI function to a different file
| export function amplifyOverrideRoot(cwd: string, settings: { testingWithLatestCodebase?: boolean }) { | ||
| return new Promise((resolve, reject) => { | ||
| const args = ['override', 'project']; | ||
| export const amplifyOverrideRoot = (cwd: string, settings: { testingWithLatestCodebase?: boolean }): Promise<void> => { |
There was a problem hiding this comment.
this file is just lint fixes
jhockett
reviewed
Nov 9, 2022
packages/amplify-e2e-tests/src/__tests__/git-clone-attach.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: John Hockett <[email protected]>
jhockett
previously approved these changes
Nov 10, 2022
sobolk
previously approved these changes
Nov 11, 2022
Comment on lines
+1
to
+3
| /** | ||
| * Shape of awscloudformation object within `--profile` payload for init/pull | ||
| */ |
There was a problem hiding this comment.
do we have a similar type in prod code base?
There was a problem hiding this comment.
we don't have an exact corollary but we have some types here that define the credential config (plus other values that it can have)
edwardfoyle
commented
Nov 11, 2022
sobolk
approved these changes
Nov 11, 2022
jhockett
approved these changes
Nov 11, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds 2 new E2E tests for exercising non-interactive pull and init in git-cloned projects
The tests simulate git cloning by using
git clean -fdxwhich removes any files not tracked by git.Issue #, if available
Description of how you validated changes
Ran new E2E tests locally and running entire suite here: https://app.circleci.com/pipelines/github/aws-amplify/amplify-cli/12411/workflows/b687e49a-4bcd-457a-bff4-b6c73ffabd15
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.