Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse true and false strings from env vars #11386

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

danielleadams
Copy link
Contributor

@danielleadams danielleadams commented Nov 14, 2022

Description of changes

Fixes type mismatch in the amplify-e2e-core module. Introduced in #11365.

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@danielleadams danielleadams requested a review from a team as a code owner November 14, 2022 15:33
aws-eddy
aws-eddy previously approved these changes Nov 14, 2022
@danielleadams
Copy link
Contributor Author

@evcodes @lazpavel @sobolk just pushed up an amended commit to handle the && correctly. Please re-review. Thanks!

@danielleadams danielleadams merged commit 5ed67f5 into aws-amplify:dev Nov 14, 2022
@danielleadams danielleadams deleted the fix-break-in-e2e-build branch November 14, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants