Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix e2e migration test broken by #11790 #11977

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

Amplifiyer
Copy link
Contributor

Description of changes

With a change in prompt string, the old test's expected prompt was not compatible.
#11790 changed the prompt

- Enter your Private Key for your OAuth flow:
+ Enter your Private Key for your OAuth flow (entire key without line breaks):

This PR changes the expected prompt to the common string Enter your Private Key for your OAuth flow for migration e2e tests.

Description of how you validated changes

cloud e2e tests
Failed -> Passed with this change

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Amplifiyer Amplifiyer requested a review from a team as a code owner February 10, 2023 16:01
Copy link
Member

@sobolk sobolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@Amplifiyer Amplifiyer merged commit 5714904 into aws-amplify:dev Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants