ci: add lint in cb #13077
Merged
ci: add lint in cb #13077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awsluja
previously approved these changes
Aug 5, 2023
awsluja
reviewed
Aug 5, 2023
| - identifier: lint | ||
| buildspec: codebuild_specs/lint.yml | ||
| env: | ||
| compute-type: BUILD_GENERAL1_LARGE |
There was a problem hiding this comment.
can you add to the other workflows
There was a problem hiding this comment.
This one is needed only in PR builds see
amplify-cli/.circleci/config.base.yml
Lines 1064 to 1068 in 392f0e2
There was a problem hiding this comment.
but it's included in dev build... so maybe it's worth adding.
awsluja
previously approved these changes
Aug 5, 2023
awsluja
reviewed
Aug 5, 2023
codebuild_specs/lint.yml
Outdated
| @@ -1,9 +1,12 @@ | |||
| version: 0.2 | |||
| env: | |||
| shell: bash | |||
| variables: | |||
| NODE_OPTIONS: --max-old-space-size=5120 | |||
awsluja
previously approved these changes
Aug 5, 2023
awsluja
previously approved these changes
Aug 5, 2023
awsluja
approved these changes
Aug 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add missing linter step.
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.