Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add lint in cb #13077

Merged
merged 5 commits into from
Aug 5, 2023
Merged

ci: add lint in cb #13077

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ffd7b6a
ci: add lint in cb
sobolk Aug 5, 2023
38e461e
ci: pr feedback
sobolk Aug 5, 2023
6d3b4ec
ci: more memory
sobolk Aug 5, 2023
e84a7d9
ci: more memory
sobolk Aug 5, 2023
51b5444
ci: really
sobolk Aug 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions codebuild_specs/e2e_workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ batch:
buildspec: codebuild_specs/test.yml
env:
compute-type: BUILD_GENERAL1_LARGE
- identifier: lint
buildspec: codebuild_specs/lint.yml
env:
compute-type: BUILD_GENERAL1_LARGE
- identifier: mock_e2e_tests
buildspec: codebuild_specs/mock_e2e_tests.yml
env:
Expand Down
4 changes: 4 additions & 0 deletions codebuild_specs/e2e_workflow_base.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ batch:
buildspec: codebuild_specs/test.yml
env:
compute-type: BUILD_GENERAL1_LARGE
- identifier: lint
buildspec: codebuild_specs/lint.yml
env:
compute-type: BUILD_GENERAL1_LARGE
- identifier: mock_e2e_tests
buildspec: codebuild_specs/mock_e2e_tests.yml
env:
Expand Down
4 changes: 4 additions & 0 deletions codebuild_specs/e2e_workflow_generated.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ batch:
buildspec: codebuild_specs/test.yml
env:
compute-type: BUILD_GENERAL1_LARGE
- identifier: lint
buildspec: codebuild_specs/lint.yml
env:
compute-type: BUILD_GENERAL1_LARGE
- identifier: mock_e2e_tests
buildspec: codebuild_specs/mock_e2e_tests.yml
env:
Expand Down
3 changes: 3 additions & 0 deletions codebuild_specs/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
version: 0.2
env:
shell: bash
variables:
NODE_OPTIONS: --max-old-space-size=5120
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

phases:
build:
commands:
- source ./shared-scripts.sh && _waitForJobs build_linux requirePrevJobsToSucceed
- source ./shared-scripts.sh && _lint
artifacts:
files:
Expand Down
4 changes: 4 additions & 0 deletions codebuild_specs/pr_workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ batch:
buildspec: codebuild_specs/test.yml
env:
compute-type: BUILD_GENERAL1_LARGE
- identifier: lint
buildspec: codebuild_specs/lint.yml
env:
compute-type: BUILD_GENERAL1_LARGE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add to the other workflows

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is needed only in PR builds see

amplify-cli/.circleci/config.base.yml

Lines 1064 to 1068 in 392f0e2

ignore:
- beta
- release
- /release_rc\/.*/
- /run-e2e\/.*/
.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but it's included in dev build... so maybe it's worth adding.

- identifier: mock_e2e_tests
buildspec: codebuild_specs/mock_e2e_tests.yml
env:
Expand Down