Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make workspace private and personal for the user #284

Closed

Conversation

hghandri
Copy link

Issue: #227

Implement private workspace, every user create a workspace now is only private and not shareable with other user.
This feature implement a new DynamoBD table handle policies on top of Workspace Dynamodb table.
This implementation could facilitate sharing workspaces between users with "is writable" option during share process like Google Drive

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bigadsoleiman
Copy link
Collaborator

@hghandri this PR is in Draft for a while, do you plan to make it ready for review or still working on it?

@abduljaleel
Copy link

Is there any plans to merge this - private workspaces are important feature for enterprise level use of this solution.

@hghandri
Copy link
Author

hghandri commented Feb 5, 2024

Hi,

I plan to work on it with the new GraphQL integration, I'll be back with new implementation.

@abduljaleel
Copy link

The current version I’m using does not include GraphQL. Could you confirm if this branch is suitable for testing for private workspace feature ?

@hghandri hghandri closed this Feb 16, 2024
@hghandri hghandri deleted the feature/make-workspace-private branch February 16, 2024 15:19
@hghandri
Copy link
Author

hghandri commented Feb 20, 2024

@abduljaleel : Hi Abdul Jaleel:

you could get these modification and adapt this new version for your current version with API Gateway.

PR : #376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants