Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let workspace private and personal by default for all user #376

Closed

Conversation

hghandri
Copy link

@hghandri hghandri commented Feb 20, 2024

Issue: #227

Implement private workspace, every user create a workspace now is only private and not shareable with other user.
This feature implement a new DynamoBD table handle policies on top of Workspace Dynamodb table.
This implementation could facilitate sharing workspaces between users with writeable / readable policy option through sharing process like Google Drive

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@massi-ang
Copy link
Collaborator

Thanks for submitting this PR. Is this changing all Workspaces to private to the user?

@hghandri
Copy link
Author

Yes by default, all workspace will be private.
If we go ahead of this feature we could add interface to set if we want to open publicly the workspace or for some people ( example fetch a user from cognito )

@massi-ang
Copy link
Collaborator

As this is a breaking change, we should either think about an opt-in/out settings or the possibility to set workspaces as public/private and retain all existing workspaces as public.

@hghandri
Copy link
Author

hghandri commented May 8, 2024

Hi,

yes this cause with my actual version a breaking change.
I will try to introduce a "Public" property we could set through workspace creation workflow.
In this case we could set arbitrary all existing workspace as Public with this property to handle a legacy behaviour.

In further with this feature the concept was to allow any user with he is private workspace could easily share he is workspace with other user or group of user. Thats why I've implemented a new DynamoDB table to handle permission.

++

@hghandri
Copy link
Author

hghandri commented May 9, 2024

I closed this PR and opened a new one with more impact.

@hghandri hghandri closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants