Add error messages in aws-k8s-agent initialization #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayanthvn
requested changes
Oct 20, 2021
|
Thanks for opening this PR. Just few minor nits. |
|
@jayanthvn Updated!! Thank you!! |
This was referenced Dec 8, 2021
Shreya027
approved these changes
Dec 12, 2021
|
@ryan-joynbio - Sorry for the delay, can you please update your branch? |
|
@jayanthvn 🙏 ty, updated!! |
jayanthvn
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature: Usability
Which issue does this PR fix:
N/A
What does this PR do / Why do we need it:
Right now if there is an error from any one of these methods, the error never gets presented to the user and debugging is impossible.
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
N/A
Testing done on this change:
N/A
Automation added to e2e:
N/A
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No. No.
Does this change require updates to the CNI daemonset config files to work?:
No.
Does this PR introduce any user-facing change?:
No.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.