Do not silently fail in k8s agent initialization #1766
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orsenthil
reviewed
Nov 24, 2021
cmd/aws-k8s-agent/main.go
Outdated
| @@ -39,17 +39,21 @@ func _main() int { | |||
| version.RegisterMetric() | |||
|
|
|||
| //Check API Server Connectivity | |||
| if k8sapi.CheckAPIServerConnectivity() != nil { | |||
| err := k8sapi.CheckAPIServerConnectivity() | |||
There was a problem hiding this comment.
Doing a direct comparison to nil since there is no other return value seems better.
So, this line can reduced to simply adding a log.Errorf
There was a problem hiding this comment.
Do you mean this ?
--- a/cmd/aws-k8s-agent/main.go
+++ b/cmd/aws-k8s-agent/main.go
@@ -40,6 +40,7 @@ func _main() int {
//Check API Server Connectivity
if k8sapi.CheckAPIServerConnectivity() != nil {
+ log.Errorf("Failed to connect to the API server")
return 1
}It would prevent to display the returned error while it contains valuable information.
|
Isnt this the same as #1650 |
|
Oh yes it is, I missed it. |
|
Closing PR as identical PR made earlier exists as mentioned above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug/cleanup
What does this PR do / Why do we need it:
It logs aws-k8s-agent initialisation error. Currently, aws-k8s-agent may fail without any error message in the log file, for example if the API server cannot be found.
*Will this break upgrades or downgrades. Has updating a running cluster been tested?**:
No.
Does this change require updates to the CNI daemonset config files to work?:
No.
Does this PR introduce any user-facing change?:
Not a change that deserve inclusion in the release notes IMHO.