Skip to content

Commit

Permalink
fix(lambda-python): allowPublicSubnet and filesystem not supported (#…
Browse files Browse the repository at this point in the history
…10022)

Fixes #10018.
Fixes #10027.

#9468 added a flag (`allowPublicSubnet`) to `FunctionProps`, but `PythonFunction` and `NodejsFunction` props derive from `FunctionOptions`. This renders these derived function constructs unable to bypass the public subnet check that occurs in the base `Function` construct. We can resolve this issue by moving `allowPublicSubnet` to `FunctionOptions`.

I also moved `filesystem` up to `FunctionOptions` while I was here.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
adamdottv authored Sep 1, 2020
1 parent ad7298f commit 745922a
Show file tree
Hide file tree
Showing 4 changed files with 450 additions and 16 deletions.
2 changes: 2 additions & 0 deletions packages/@aws-cdk/aws-lambda-python/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,14 @@
"dependencies": {
"@aws-cdk/aws-lambda": "0.0.0",
"@aws-cdk/core": "0.0.0",
"@aws-cdk/aws-ec2": "0.0.0",
"constructs": "^3.0.4"
},
"homepage": "https://github.com/aws/aws-cdk",
"peerDependencies": {
"@aws-cdk/aws-lambda": "0.0.0",
"@aws-cdk/core": "0.0.0",
"@aws-cdk/aws-ec2": "0.0.0",
"constructs": "^3.0.4"
},
"engines": {
Expand Down
Loading

0 comments on commit 745922a

Please sign in to comment.