Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws-lambda-python] mount EFS filesystem #10027

Closed
2 tasks
metgrahamr opened this issue Aug 28, 2020 · 0 comments · Fixed by #10022
Closed
2 tasks

[aws-lambda-python] mount EFS filesystem #10027

metgrahamr opened this issue Aug 28, 2020 · 0 comments · Fixed by #10022
Assignees
@eladb
Labels
@aws-cdk/aws-lambda-python feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@metgrahamr
Copy link

Include the filesystem property in PythonFunction that is already available in aws_lambda.Function.

Use Case

Automatic bundling of dependencies when creating the Lambda function is great. Being able to mount an EFS file system to a Lambda is also great. Having the option to do both would be really useful, e.g. install dependencies that allow Lambda function to interact with data on an EFS file system, such as xarray and cfgrib to read grib files from EFS.

Proposed Solution

Use the filesystem property available in aws_lambda.Function.

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@metgrahamr metgrahamr added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 28, 2020
@adamdottv adamdottv mentioned this issue Aug 28, 2020
Merged
@SomayaB SomayaB changed the title aws_lambda_python mount EFS filesystem [aws-lambda-python] mount EFS filesystem Aug 31, 2020
@mergify mergify bot closed this as completed in #10022 Sep 1, 2020
mergify bot pushed a commit that referenced this issue Sep 1, 2020
@adamdottv
fix(lambda-python): allowPublicSubnet and filesystem not supported (#…
745922a 
…10022)

Fixes #10018.
Fixes #10027.

#9468 added a flag (`allowPublicSubnet`) to `FunctionProps`, but `PythonFunction` and `NodejsFunction` props derive from `FunctionOptions`. This renders these derived function constructs unable to bypass the public subnet check that occurs in the base `Function` construct. We can resolve this issue by moving `allowPublicSubnet` to `FunctionOptions`.

I also moved `filesystem` up to `FunctionOptions` while I was here.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eladb eladb

Labels
@aws-cdk/aws-lambda-python feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(lambda-python): allowPublicSubnet and filesystem not supported
2 participants
@eladb @metgrahamr